Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incentives: Support heartbeat txn, Java 8 Min Version #758

Merged
merged 6 commits into from
Jan 14, 2025
Merged

Incentives: Support heartbeat txn, Java 8 Min Version #758

merged 6 commits into from
Jan 14, 2025

Conversation

algorandskiy
Copy link
Contributor

@algorandskiy algorandskiy commented Dec 23, 2024 •
edited
Loading

Support new Heartbeats transaction fields.

Added deserialization test from a golden txn.
Pulled #759 in and added few cross-sdk tests.

@algorandskiy algorandskiy self-assigned this Dec 23, 2024
@algorandskiy algorandskiy changed the title Support HeartbeatTxnFields Transactions: Support HeartbeatTxnFields Dec 23, 2024
@algorandskiy algorandskiy requested a review from a team as a code owner December 27, 2024 15:16
@gmalouf gmalouf changed the title Transactions: Support HeartbeatTxnFields Transactions: Support HeartbeatTxnFields, Java 8 Min Version Dec 27, 2024
gmalouf

This comment was marked as outdated.

Sign in to view

@gmalouf
Copy link
Contributor

gmalouf commented Dec 27, 2024

I'm not sure we should merged in the transaction package changes - that package is used for submitting transactions to algod, vs those in v2.client.model.Transaction that are used for the API responses. Check out #759

This comment was wrong and threw me off. The Transaction in this package gets wrapped in SignedTransaction and used to parse responses from the pending transactions endpoint (in algod).

@algorandskiy algorandskiy mentioned this pull request Jan 3, 2025
Closed
@algorandskiy algorandskiy requested a review from gmalouf January 3, 2025 20:21
@gmalouf gmalouf mentioned this pull request Jan 6, 2025
Closed
@gmalouf gmalouf requested review from gmalouf and removed request for gmalouf January 6, 2025 17:54
@algorandskiy algorandskiy changed the title Transactions: Support HeartbeatTxnFields, Java 8 Min Version Incentives: Support heartbeat txn, Java 8 Min Version Jan 14, 2025
@algorandskiy algorandskiy merged commit 35d8ab4 into develop Jan 14, 2025
6 checks passed
@algorandskiy algorandskiy deleted the pavel/heartbeats branch January 14, 2025 19:53
@github-actions github-actions bot mentioned this pull request Jan 15, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmalouf gmalouf gmalouf approved these changes

@onetechnical onetechnical Awaiting requested review from onetechnical onetechnical is a code owner automatically assigned from algorand/devops

Assignees

@algorandskiy algorandskiy

Labels
Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@algorandskiy @gmalouf @algo-dev-service