partkey registry: Single signature onetimesig. #5825
Conversation
| // Delete all secrets except for the requested round | ||
| snap := result.ParticipationRecord.Voting.Snapshot() | ||
| otsID := basics.OneTimeIDForRound(round, result.KeyDilution) | ||
| snap.DeleteBeforeFineGrained(otsID, result.KeyDilution) | ||
| snap.DeleteAllButFineGrained(otsID) | ||
| result.ParticipationRecord.Voting = &snap |
There was a problem hiding this comment.
The heart of the change is this block of code in the participation registry. Stripping out the extra stuff and seeing that the network operates properly shows that a subset of secrets may be returned without any trouble and the existing public interface doesn't require any changes.
Codecov Report
@@ Coverage Diff @@
## master #5825 +/- ##
==========================================
+ Coverage 55.61% 55.63% +0.01%
==========================================
Files 475 475
Lines 66909 66933 +24
==========================================
+ Hits 37212 37236 +24
+ Misses 27182 27181 -1
- Partials 2515 2516 +1
... and 14 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
Summary
This change locks down the participation registry such that the participationID for a requested round only includes voting secrets for that particular round.
Test Plan
New unit tests for onetimesignature changes.
All existing e2e tests hit this code and serve as regression tests.
Manual testing with
FiveNodesTwoRelays.jsontemplate show the network making progress.