ledger: support WaitWithCancel for unsuccessful WaitForBlock API calls #5814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5814 +/- ##
==========================================
+ Coverage 54.45% 55.55% +1.10%
==========================================
Files 475 475
Lines 66848 66860 +12
==========================================
+ Hits 36399 37144 +745
+ Misses 27903 27194 -709
+ Partials 2546 2522 -24
... and 84 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
algorandskiy
previously approved these changes
Oct 30, 2023
jannotti
reviewed
Oct 31, 2023
jannotti
previously approved these changes
Oct 31, 2023
|
Updated to remove unnecessary atomic CompareAndSwap (since notifier is only ever used under lock by bulletin). I think the original purpose of notifier's atomic operation was in case it would ever be used by other types besides bulletin, but it is only used by bulletin today. |
algorandskiy
approved these changes
Nov 1, 2023
jannotti
reviewed
Nov 1, 2023
jannotti
approved these changes
Nov 1, 2023
cce
approved these changes
Nov 6, 2023
This was referenced Nov 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The REST API WaitForBlockAfter call creates a notifier for each unique round requested, which remains present even if the HTTP request times out. This adds the ability to cancel and delete notifiers if no one wants them.
Test Plan
Added TestCancelWait