Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javascript): react-native lite resolution #3771

Merged
merged 1 commit into from
Sep 18, 2024

Conversation

shortcuts
Copy link
Member

@shortcuts shortcuts commented Sep 18, 2024

🧭 What and Why

🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2948

Changes included:

fixes algolia/algoliasearch-client-javascript#1554 (comment)

the lite package also needs to have an entry point in the react-native field.

this object syntax is supported for every fields normally, so I hope it also works for react native

also adds the react-native field for the browser-xhr and fetch requester

@shortcuts shortcuts self-assigned this Sep 18, 2024
@shortcuts shortcuts requested a review from a team as a code owner September 18, 2024 15:10
@shortcuts shortcuts changed the title Fix/react native resolution fix(javascript): react-native lite resolution Sep 18, 2024
@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 18, 2024

✔️ Code generated!

Name Link
🪓 Triggered by 8fe37c7d2d1093260ba74edf394da4eb7949251a
🍃 Generated commit 5ae2c83838c4214f6c10486ba306844abf2f5630
🌲 Generated branch generated/fix/react-native-resolution
📊 Benchmark results

Benchmarks performed on the method using a mock server, the results might not reflect the real-world performance.

Language Req/s
javascript 1675

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the never ending fix

@shortcuts shortcuts enabled auto-merge (squash) September 18, 2024 15:17
@shortcuts shortcuts merged commit 9010765 into main Sep 18, 2024
13 of 14 checks passed
@shortcuts shortcuts deleted the fix/react-native-resolution branch September 18, 2024 15:23
algolia-bot added a commit that referenced this pull request Sep 18, 2024
…kip ci]

Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Sep 18, 2024
algolia/api-clients-automation#3771

Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com>
Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants