fix(csharp): remove global enum converter #3765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
morganleroi
changed the title
|
what is the usage of those enum ? currently in the snippets its like |
|
Yes, for the snippet it could be |
millotp
approved these changes
Sep 17, 2024
algolia-bot
added a commit
that referenced
this pull request
Sep 18, 2024
Co-authored-by: Morgan Leroi <morgan.leroi@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-csharp
that referenced
this pull request
Sep 18, 2024
algolia/api-clients-automation#3765 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Morgan Leroi <morgan.leroi@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
This PR removes the global Enum to string converter from the Serializer configuration and move this to every Algolia POCO enum. It means that only Algolia POCO enum will be converted as string. Every other enum will be converter as int (default behaviour from System.Text.Json or NewtonSoft).
With this PR, the generated client behaves the same way the legacy one.
Please note that we do not use
JsonStringEnumConverterfromSystem.Text.Jsonbecause our enum values are flagged with custom name.Changes included: