feat(javascript): add requester-testing package #3684
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✔️ Code generated!
📊 Benchmark resultsBenchmarks performed on the method using a mock server, the results might not reflect the real-world performance.
|
shortcuts
commented
Sep 10, 2024
| @@ -19,34 +19,29 @@ | |||
| "types": { | |||
| "import": "./dist/common.d.ts", | |||
| "module": "./dist/common.d.ts", | |||
| "require": "./dist/common.d.cts", | |||
| "default": "./dist/common.d.cts" | |||
There was a problem hiding this comment.
that's a lefover, tsup warns when having a default with import and require saying that it would never be used
millotp
reviewed
Sep 10, 2024
| @@ -317,19 +325,22 @@ describe('search with legacy signature', () => { | |||
| expect(req.data).toEqual({ | |||
| requests: [{ indexName: 'theIndexName', hitsPerPage: 42 }], | |||
| }); | |||
| expect(req.searchParams).toStrictEqual(undefined); | |||
| expect(req.searchParams).toStrictEqual({ | |||
There was a problem hiding this comment.
is this change expected ?
algolia-bot
added a commit
that referenced
this pull request
Sep 10, 2024
…skip ci] Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
algolia-bot
added a commit
to algolia/algoliasearch-client-javascript
that referenced
this pull request
Sep 10, 2024
algolia/api-clients-automation#3684 Co-authored-by: algolia-bot <accounts+algolia-api-client-bot@algolia.com> Co-authored-by: Clément Vannicatte <vannicattec@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/DI-2853 https://algolia.atlassian.net/browse/DI-2889
close algolia/algoliasearch-client-javascript#1547
Changes included:
The echo requesters we expose for internal testing purposes contains environment dependant imports (e.g. URL), which lead the clients to be unusable if the user environment doesn't support it
We now have a new private
@algolia/requester-testingpackage, that isn't shipped with the clients and will be used for our test suites, which also allows the@algolia/client-commonpackage to be agnostic.Jest to Vitest
I've moved the
requester-*/client-common/algoliasearchmanual tests tovitest, sincejestis unable to run esm code (or I didn't managed to?), I wanted to do that since a long time, CTS is next on the list!The
clients/algoliasearch-client-javascript/packages/algoliasearch/__tests__/algoliasearch.common.test.tssuite also runs on the browser bundle now, since the CTS runs on node only, it gives us a bit more safety for potential regressions