Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some calls to unwrap #113

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

sdwoodbury
Copy link

@sdwoodbury sdwoodbury commented Jul 5, 2023

This PR removes a lot of calls to unwrap. The ones left in are guaranteed to not fail.

I added a new error type and may have not used the correct error everywhere.

The Mp4Box trait was used to implement to_json since all the things that implement it are serializable.

Thanks for making this crate available. Hope this helps.

@sdwoodbury sdwoodbury marked this pull request as draft July 5, 2023 16:01
@sdwoodbury sdwoodbury marked this pull request as ready for review July 5, 2023 17:12
@alfg
Copy link
Owner

alfg commented Aug 3, 2023

Thanks @sdwoodbury. I merged in a few recent PRs and there's now a conflict if you can fix and I'll get this through. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants