Don't set page title/location for external protocols

Fix brave#1018 Auditors: @bbondy
alexwykoff · Apr 28, 2016 · 27e61f2 · 27e61f2
1 parent d6c4a44
commit 27e61f2
Showing 1 changed file with 4 additions and 1 deletion.
diff --git a/js/components/frame.js b/js/components/frame.js
@@ -325,8 +325,11 @@ class Frame extends ImmutableComponent {
         windowActions.onWebviewLoadStart(
           this.props.frame)
         const key = this.props.frame.get('key')
-        windowActions.setLocation(event.url, key)
         const parsedUrl = urlParse(event.url)
+        if (['http:', 'https:', 'about:', 'chrome:', 'chrome-extension:', 'file:',
+             'view-source:'].includes(parsedUrl.protocol)) {
+          windowActions.setLocation(event.url, key)
+        }
         const hack = siteHacks[parsedUrl.hostname]
         const isSecure = parsedUrl.protocol === 'https:' &&
           (!hack || !hack.allowRunningInsecureContent)