-
Notifications
You must be signed in to change notification settings - Fork 15
Fix importing KMP sources #2531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @alexvanyo, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses an issue with importing Kotlin Multiplatform (KMP) sources. It adds a temporary workaround by enabling the kotlin.kmp.isolated-projects.support
flag in the gradle.properties
file. This flag helps resolve dependency resolution failures in commonTest/nativeTest source sets when depending on another project.
Highlights
- KMP Source Import Fix: The pull request implements a workaround for a KMP source import issue.
- gradle.properties Update: The
gradle.properties
file is modified to enablekotlin.kmp.isolated-projects.support
. - Temporary Solution: The implemented fix is intended as a temporary solution until the underlying issue (KT-75605) is resolved in Kotlin.
Changelog
- gradle.properties
- Added
kotlin.kmp.isolated-projects.support=auto
to address KMP source import issues. - Included a comment referencing the related YouTrack issue (KT-75605) for future removal of the workaround.
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A KMP fix,
A flag to assist,
Until the true fix,
Arrives to mix,
Then this workaround we dismiss.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
The pull request adds a temporary workaround for a known Kotlin Multiplatform (KMP) issue. The solution involves enabling isolated projects support. This is a reasonable approach given the circumstances. The added comment clearly explains the purpose and provides a link to the issue tracker. I have a suggestion to improve the comment, and to ensure the workaround is removed when the issue is resolved.
Summary of Findings
- Clarity of TODO comment: The TODO comment could be improved by specifying the exact version or event that triggers the removal of the workaround.
Merge Readiness
The pull request introduces a temporary workaround with a clear explanation and a link to the relevant issue. The change seems reasonable and necessary. I recommend addressing the comment suggestion to improve the clarity of the TODO. Given that this is a workaround, it's important to ensure it's removed once the underlying issue is resolved. I am unable to approve the pull request, and other reviewers should review and approve this code before merging.
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #2531 +/- ##
=========================================
Coverage 68.32% 68.33%
Complexity 563 563
=========================================
Files 260 260
Lines 13328 13328
Branches 1642 1642
=========================================
+ Hits 9107 9108 +1
Misses 3571 3571
+ Partials 650 649 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
1187f2f
to
48bf5d7
Compare
No description provided.