Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initial Coil rendering with graphicsLayer #2283

Merged
merged 10 commits into from
Feb 4, 2025

Conversation

alexvanyo
Copy link
Owner

Fixes #2282

Copy link

codecov bot commented Dec 28, 2024

Codecov Report

Attention: Patch coverage is 30.00000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 63.41%. Comparing base (176a1ec) to head (52149a5).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mposelife/ui/cells/CellStateDragAndDrop.android.kt 30.00% 13 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main    #2283   +/-   ##
=========================================
  Coverage     63.41%   63.41%           
  Complexity      518      518           
=========================================
  Files           235      235           
  Lines         12488    12495    +7     
  Branches       2217     2219    +2     
=========================================
+ Hits           7919     7924    +5     
- Misses         3380     3382    +2     
  Partials       1189     1189           
Flag Coverage Δ
21 63.40% <30.00%> (-0.01%) ⬇️
22 ?
24 ?
25 ?
26 ?
27 ?
28 ?
29 ?
30 ?
32 ?
33 ?
34 ?
35 63.40% <30.00%> (+<0.01%) ⬆️
unit 63.41% <30.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Base automatically changed from av/cell-state-drop-state to main December 28, 2024 07:10
@alexvanyo alexvanyo force-pushed the av/fix-initial-coil-rendering branch from a484c65 to 7802535 Compare December 28, 2024 16:58
@alexvanyo alexvanyo marked this pull request as ready for review December 28, 2024 16:58
@alexvanyo alexvanyo enabled auto-merge (rebase) December 28, 2024 16:58
@alexvanyo alexvanyo force-pushed the av/fix-initial-coil-rendering branch from 7802535 to d70ae71 Compare December 28, 2024 17:12
@alexvanyo alexvanyo disabled auto-merge December 28, 2024 17:23
@alexvanyo alexvanyo force-pushed the av/fix-initial-coil-rendering branch from d70ae71 to bb579d5 Compare December 28, 2024 17:37
@alexvanyo alexvanyo enabled auto-merge (rebase) December 28, 2024 17:38
@alexvanyo alexvanyo force-pushed the av/fix-initial-coil-rendering branch from a279e82 to 22899e3 Compare February 2, 2025 23:36
@alexvanyo alexvanyo merged commit a37cfbe into main Feb 4, 2025
20 of 21 checks passed
@alexvanyo alexvanyo deleted the av/fix-initial-coil-rendering branch February 4, 2025 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cells rendering with Coil not rendering initially
1 participant