Forward-looking (FL) and Detailed Balance (DB) losses #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carriepl
reviewed
Nov 27, 2023
carriepl
reviewed
Nov 27, 2023
…simple enough to do in place
… state_flow inside gflownet
Changes to main FL loss PR
Co-authored-by: Alex <alexhg15@gmail.com>
Co-authored-by: Alex <alexhg15@gmail.com>
Co-authored-by: Alex <alexhg15@gmail.com>
Move squeeze to state flow call
Co-authored-by: Alexandra <alexandra.volokhova@mila.quebec>
Co-authored-by: Alexandra <alexandra.volokhova@mila.quebec>
FL loss cosmetics
Detailed Balance loss
FL loss final cosmetics
alexhernandezgarcia
changed the title
Co-authored-by: Alex <alexhg15@gmail.com>
This was referenced Nov 29, 2023
alexhernandezgarcia
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forward-looking loss implementation based on https://arxiv.org/abs/2302.01687 and the previous PR: #127
Detailed balance loss implementation based on https://arxiv.org/abs/2201.13259
Wandb report with comparison FL v.s. TB on ctorus and grid: https://wandb.ai/alexandra-volokhova/gfn-dev/reports/Forward-looking-loss-dev--Vmlldzo2MTE4MzMw
Added sanity check experiments with new DB and FL losses (see wandb)