Small updates to build and docs.

CONTRIBUTING.rst

@@ -8,8 +8,9 @@ If you would like to contribute to the code, the process is pretty simple:
 1. Familiarise yourself with this package and its dependencies.
 2. Fork `the repository on GitHub <https://github.com/alexdlaird/hookee>`_ and start implementing changes.
 3. Write a test that plainly validates the changes made.
-4. Build and test locally with ``make local test``
-5. Submit a `pull requests <https://help.github.com/en/articles/creating-a-pull-request-from-a-fork>`_ to get the changes merged.
+4. Build and test locally with ``make local`` and ``make test``
+5. Ensure no linting errors were introduced by running ``make check``
+6. Submit a `pull requests <https://help.github.com/en/articles/creating-a-pull-request-from-a-fork>`_ to get the changes merged.
 
 Also be sure to review the `Code of Conduct <https://github.com/alexdlaird/hookee/blob/main/CODE_OF_CONDUCT.md>`_ before
 submitting issues or pull requests.

Makefile

@@ -1,19 +1,18 @@
-.PHONY: all virtualenv install nopyc clean test docs check local validate-release upload
+.PHONY: all install nopyc clean test docs check local validate-release upload
 
 SHELL := /usr/bin/env bash
 PYTHON_BIN ?= python
+PROJECT_VENV ?= venv
 
-all: virtualenv install
+all: local check test
 
-virtualenv:
-	@if [ ! -d "venv" ]; then \
-		$(PYTHON_BIN) -m pip install virtualenv --user; \
-		$(PYTHON_BIN) -m virtualenv venv; \
-	fi
+venv:
+	$(PYTHON_BIN) -m pip install virtualenv --user
+	$(PYTHON_BIN) -m virtualenv $(PROJECT_VENV)
 
-install: virtualenv
+install: venv
 	@( \
-		source venv/bin/activate; \
+		source $(PROJECT_VENV)/bin/activate; \
 		python -m pip install .; \
 	)
 
@@ -22,25 +21,25 @@ nopyc:
 	find . -name __pycache__ | xargs rm -rf || true
 
 clean: nopyc
-	rm -rf build dist *.egg-info venv
+	rm -rf build dist *.egg-info $(PROJECT_VENV)
 
-test: virtualenv
+test: install
 	@( \
-		source venv/bin/activate; \
+		source $(PROJECT_VENV)/bin/activate; \
 		python -m pip install ".[dev]"; \
 		coverage run -m unittest discover -v -b && coverage report && coverage xml && coverage html; \
 	)
 
-docs: virtualenv
+docs: install
 	@( \
-		source venv/bin/activate; \
+		source $(PROJECT_VENV)/bin/activate; \
 		python -m pip install ".[docs]"; \
 		sphinx-build -M html docs build/docs; \
 	)
 
-check: virtualenv
+check: install
 	@( \
-		source venv/bin/activate; \
+		source $(PROJECT_VENV)/bin/activate; \
 		python -m pip install ".[dev,docs]"; \
 		flake8; \
 	)