Skip to content

Commit

Permalink
Merge pull request #260 from kesselb/enh/make-last-modified-a-optiona…
Browse files Browse the repository at this point in the history
…l-property

A item without pubDate seems to be valid.
  • Loading branch information
alexdebril authored Jan 27, 2020
2 parents c651b6f + 3ef5d65 commit e4d2f23
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/FeedIo/Filter/ModifiedSince.php
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,6 @@ public function isValid(ItemInterface $item) : bool
return $item->getLastModified() > $this->date;
}

return false;
return true;
}
}
2 changes: 1 addition & 1 deletion tests/FeedIo/Filter/ModifiedSinceTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,6 @@ public function testIsTooOld()
public function testIsNotValid()
{
$item = new Item();
$this->assertFalse($this->object->isValid($item));
$this->assertTrue($this->object->isValid($item));
}
}

0 comments on commit e4d2f23

Please sign in to comment.