Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update author email #3

Closed
wants to merge 2 commits into from
Closed

Update author email #3

wants to merge 2 commits into from

Conversation

hamogu
Copy link
Contributor

@hamogu hamogu commented Mar 27, 2024

I don't know how long the MIT email is going to continue to work, so seems like a good time to change it to your current institution.

@alexbinks
Copy link
Owner

I've changed the email in the readme file. MIT --> Tuebingen.

@alexbinks alexbinks closed this Mar 27, 2024
Copy link
Owner

@alexbinks alexbinks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for noticing that my email address needs updating. We can close this one now.

@hamogu
Copy link
Contributor Author

hamogu commented Mar 27, 2024

You could have also accepted this PR, which would have then included both my changes into the main branch of the tesslilator. For two lines of changes either will work, but for more complex changes (which I or other people might suggest in the future) you probably want to go with accepting the PR. Plus, that way the person who wrote that code is associated with that commit through their commit email address. Again, not important for this, but for larger changes, people might want to say in their CV "and I also contributed XXX commits to astropy and YYY commits to tessilator".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants