Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating SoftParser: Go-to-definition code provider for SoftAST #360

Merged
merged 8 commits into from
Jan 30, 2025
Merged

Integrating SoftParser: Go-to-definition code provider for SoftAST #360

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
48d93b6
added type `S` to `CodeProvider`
simerplaha Jan 28, 2025
dda6a9d
Make `SoftAST.toNode` lazily evaluated
simerplaha Jan 28, 2025
593c61d
Execute `SoftParser` during parser state and store `SoftAST` in `Sour…
simerplaha Jan 28, 2025
3175bba
Implemented go-to-definition provider for `SoftAST`
simerplaha Jan 28, 2025
2dec520
fix build
simerplaha Jan 28, 2025
afb4945
Address review comment: Remove redundant inheritance
simerplaha Jan 29, 2025
acc77b2
Assert equality of `goToDefinition` results
simerplaha Jan 29, 2025
e09c4e1
Merge remote-tracking branch 'origin/master' into integrate_soft_ast_…
simerplaha Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions presentation-compiler/src/test/scala/org/alephium/ralph/lsp/pc/search/TestCodeProvider.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,16 @@ object TestCodeProvider {

/** Executes go-to-definition providers for both StrictAST and [[SoftAST]] */
def goToDefinition(settings: GoToDefSetting = testGoToDefSetting)(code: String): List[(URI, LineRange)] = {
goToDefinitionStrict(settings)(code)
goToDefinitionSoft(settings)(code)
val resultStrict = goToDefinitionStrict(settings)(code)
val resultStrictRanges = resultStrict.map(_._2)

val resultSoft = goToDefinitionSoft(settings)(code)
val resultSoftRanges = resultSoft.map(_._2)

// Assert that both go-to-def services (Strict & Soft) return the same result.
resultSoftRanges should contain theSameElementsAs resultStrictRanges
// return either one of the results because they both contain the same result
resultSoft
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}

def goToDefinitionForAll(
Expand Down