Integrating SoftParser: Go-to-definition code provider for SoftAST
#360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdroxler
reviewed
Jan 28, 2025
| extends IsParsedAndCompiled | ||
| with IsParsed |
There was a problem hiding this comment.
why do we need both?
extends IsParsedAndCompiled
with IsParsed
There was a problem hiding this comment.
You are right 👍🏼. We don't. Removed.
tdroxler
reviewed
Jan 28, 2025
| /** Executes go-to-definition providers for both StrictAST and [[SoftAST]] */ | ||
| def goToDefinition(settings: GoToDefSetting = testGoToDefSetting)(code: String): List[(URI, LineRange)] = { | ||
| goToDefinitionStrict(settings)(code) | ||
| goToDefinitionSoft(settings)(code) |
There was a problem hiding this comment.
both are executed, but only the results of the soft one are returned, is it expected or you miss a ++ ?
There was a problem hiding this comment.
++ is not required. When a go-to-def test is executed on both Strict and Soft ASTs, they both should return the same result. Running the test already asserts this, but I'll make this explicit by checking it in this function.
tdroxler
reviewed
Jan 29, 2025
| // Assert that both go-to-def services (Strict & Soft) return the same result. | ||
| resultSoftRanges should contain theSameElementsAs resultStrictRanges | ||
| // return either one of the results because they both contain the same result | ||
| resultSoft |
tdroxler
approved these changes
Jan 29, 2025
…0_provider # Conflicts: # presentation-compiler/src/main/scala/org/alephium/ralph/lsp/pc/sourcecode/SourceCodeState.scala
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CodeProviderforSoftAST. This first version is only for handling local variables, no scoping or inheritance is handled yet.goToDefinition()- Runs on both Strict and Soft asts.goToDefinitionSoft()Runs only onSoftASTbecause Strict AST results in parser error. Notice, the number of cases we can handle withSoftASThave increased, showing that go-to-definitions is available even with syntax errors.SoftParseris lazily executed. Node's parser is still the primary parser until the integration is complete.CodeProviderexecution (completion, goto definition etc) #104.