-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parser updates #358
Merged
Merged
Parser updates #358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s, structs, tuples, contracts, txscript etc
…eOrFail` for consistency
- update `TypeAssignmentParser` - Narrow executed parsers for `MethodCall`s left expression
tdroxler
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExpressionParser.parse
is called in multiple places where anExpression
is required. The number of expression parsers executed need to be narrowed down to only the required expressions. For example, parsing afor
expression withwhile
expressionfor(while(); ....)
is unnecessary. This optimisation is not a priority for now.CodeProvider
can begin. Remaining parsers likeenum
,abstract
,mapping
, braces syntax etc., will be added later.CodeProvider
execution (completion, goto definition etc) #104.