Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move test constructors out from SoftAST to TestSoftAST #339

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

simerplaha
Copy link
Member

These constructors are used only by test-cases, therefore, should not be in production code.

The constructors reduce the amount of code needed for each test-case by a small margin (see number of lines).

@simerplaha simerplaha requested a review from tdroxler December 12, 2024 04:16
Copy link
Member

@tdroxler tdroxler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Damn, that's the kind of PR I love!

image

Just perfect

@simerplaha simerplaha merged commit dcd783c into master Dec 12, 2024
3 checks passed
@simerplaha simerplaha deleted the test_constructors branch December 12, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants