Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scalafmt #147

Closed
wants to merge 3 commits into from
Closed

Scalafmt #147

wants to merge 3 commits into from

Conversation

tdroxler
Copy link
Member

I think I found a good tradeoff that introduces very little changes. I see two main ones:

types of functions are move to the next line

image

Class definition, when there is enough place into the 120 columns, they are put in one line

image

Beside that, no big changes

@tdroxler tdroxler requested a review from simerplaha March 15, 2024 13:45
@tdroxler tdroxler force-pushed the scalafmt branch 7 times, most recently from 76a9c45 to ff6539f Compare March 15, 2024 16:42
@tdroxler tdroxler force-pushed the scalafmt branch 2 times, most recently from 4fe3c73 to eb2d9fb Compare March 15, 2024 16:49
@tdroxler tdroxler changed the title [DO NOT MERGE] Scalafmt Scalafmt Mar 15, 2024
@tdroxler
Copy link
Member Author

I added the scalafmt check in CI, also took the opportunity to use matrix in our workflow, so we can easily add some os and java version.
We now also run CI on MacOS

@tdroxler tdroxler closed this Mar 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant