Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formatter & Linter #236

Open
polarker opened this issue Jul 5, 2024 · 3 comments
Open

Formatter & Linter #236

polarker opened this issue Jul 5, 2024 · 3 comments

Comments

@polarker
Copy link
Member

polarker commented Jul 5, 2024

To be researched

@tdroxler
Copy link
Member

tdroxler commented Jul 8, 2024

we do have scalafmt, no scalastyle yet

Sorry I thought for the scala part, just saw your message on Discord.

@tdroxler
Copy link
Member

tdroxler commented Jul 8, 2024

This is about Formatting Request.

We'll investigate.

@tdroxler
Copy link
Member

@polarker I started to look at formatting, but I see one big problem: comments

We are not keeping them in our AST, adding them might be a bit ugly as we need them in a lot of place, but I could give a try.

But I might get back to the discussion of having a parse phase to build a "Parse tree" or "Concrete Syntax Tree".

From https://en.wikipedia.org/wiki/Abstract_syntax_tree :

Parse trees are typically built by a parser during the source code translation and compiling process. Once built, additional information is added to the AST by means of subsequent processing, e.g., contextual analysis.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants