From dde53f1ec3b459ebf6d94c24b7a5b2ebe7c8c537 Mon Sep 17 00:00:00 2001
From: simerplaha <simer.j@gmail.com>
Date: Mon, 13 Jan 2025 19:14:44 +1100
Subject: [PATCH] private `boolean` always return expression

---
 .../lsp/access/compiler/parser/soft/BooleanParser.scala   | 8 ++++----
 .../access/compiler/parser/soft/ExpressionParser.scala    | 2 +-
 .../access/compiler/parser/soft/BooleanParserSpec.scala   | 6 +++---
 .../lsp/access/compiler/parser/soft/TestParser.scala      | 2 +-
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParser.scala b/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParser.scala
index bc7c3ae26..eaaaada4b 100644
--- a/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParser.scala
+++ b/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParser.scala
@@ -5,10 +5,10 @@ import org.alephium.ralph.lsp.access.compiler.parser.soft.ast.{SoftAST, Token}
 
 object BooleanParser {
 
-  def parseOrFail[Unknown: P]: P[SoftAST.TokenDocumented[Token.PrimitiveBoolean]] =
-    P(TokenParser.parseOrFail(Token.True) | TokenParser.parseOrFail(Token.False))
+  def parseOrFail[Unknown: P]: P[SoftAST.TokenExpression[Token.PrimitiveBoolean]] =
+    P(boolean) map (SoftAST.TokenExpression(_))
 
-  def parseOrFailExpression[Unknown: P]: P[SoftAST.TokenExpression[Token.PrimitiveBoolean]] =
-    P(parseOrFail) map (SoftAST.TokenExpression(_))
+  private def boolean[Unknown: P]: P[SoftAST.TokenDocumented[Token.PrimitiveBoolean]] =
+    P(TokenParser.parseOrFail(Token.True) | TokenParser.parseOrFail(Token.False))
 
 }
diff --git a/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/ExpressionParser.scala b/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/ExpressionParser.scala
index e5f8c8eaf..053fbdd0f 100644
--- a/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/ExpressionParser.scala
+++ b/compiler-access/src/main/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/ExpressionParser.scala
@@ -83,7 +83,7 @@ private object ExpressionParser {
         ReferenceCallParser.parseOrFail |
         AnnotationParser.parseOrFail |
         TupleParser.parseOrFail |
-        BooleanParser.parseOrFailExpression |
+        BooleanParser.parseOrFail |
         IdentifierParser.parseOrFail
     }
 
diff --git a/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParserSpec.scala b/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParserSpec.scala
index 8dacd2840..870370c9c 100644
--- a/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParserSpec.scala
+++ b/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/BooleanParserSpec.scala
@@ -10,11 +10,11 @@ import org.scalatest.OptionValues._
 class BooleanParserSpec extends AnyWordSpec with Matchers {
 
   "true" in {
-    parseBoolean("true") shouldBe True(indexOf(">>true<<"))
+    parseBoolean("true").token shouldBe True(indexOf(">>true<<"))
   }
 
   "false" in {
-    parseBoolean("false") shouldBe False(indexOf(">>false<<"))
+    parseBoolean("false").token shouldBe False(indexOf(">>false<<"))
   }
 
   "boolean with comments" in {
@@ -24,7 +24,7 @@ class BooleanParserSpec extends AnyWordSpec with Matchers {
           parseBoolean {
             s"""// comment
                |$bool""".stripMargin
-          }
+          }.token
 
         // has comment
         result.documentation.value.comments should have size 1
diff --git a/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/TestParser.scala b/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/TestParser.scala
index 090e9c9b6..2efad43d6 100644
--- a/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/TestParser.scala
+++ b/compiler-access/src/test/scala/org/alephium/ralph/lsp/access/compiler/parser/soft/TestParser.scala
@@ -63,7 +63,7 @@ object TestParser {
   def parseIdentifier(code: String): SoftAST.IdentifierAST =
     runSoftParser(IdentifierParser.parseOrFail(_))(code)
 
-  def parseBoolean(code: String): SoftAST.TokenDocumented[Token.PrimitiveBoolean] =
+  def parseBoolean(code: String): SoftAST.TokenExpression[Token.PrimitiveBoolean] =
     runSoftParser(BooleanParser.parseOrFail(_))(code)
 
   def findAnnotation(identifier: String)(code: String): Option[SoftAST.Annotation] =