Remove cli stacktrace from cli error output #303

ross-weir · 2024-01-16T08:56:56Z

New output from compile command:

Full node version: v2.5.7
Compiling contracts in folder "contracts"
✘ Failed to compile, error: [API Error] - org.alephium.ralph.Compiler$Error: -- error (9:3): Syntax error
9 |  event Hello(
  |  ^^^^^^^^^^
  |  Expected "}"
  |-------------------------------------------------------------------------------------
  |Trace log: Expected multiContract:1:1 / rawContract:1:1 / "}":9:3, found "event Fund"

packages/cli/cli.js

packages/cli/cli_internal.ts

polarker · 2024-01-18T08:49:59Z

packages/cli/cli_internal.ts

@@ -168,7 +174,7 @@ program
      const toIndex = tryGetScriptIndex(options.to)
      await deployAndSaveProgress(config, networkId, fromIndex, toIndex)
    } catch (error) {
-      program.error(`Failed to deploy contracts, error: ${(error as Error).stack}`)
+      program.error(`✘ Failed to deploy contracts, error: ${buildErrorOutput(error, options.debug)}`)


If debug is enabled via the config file, should we also show the debug info? It looks good to keep the two debug flag consistent.

If debug is enabled via the config file, should we also show the debug info? It looks good to keep the two debug flag consistent.

Yeah good point, updated

remove cli stacktrace from cli error output

f91ce03

github-advanced-security bot found potential problems Jan 16, 2024

View reviewed changes

packages/cli/cli.js Dismissed Show dismissed Hide dismissed

polarker reviewed Jan 16, 2024

View reviewed changes

packages/cli/cli_internal.ts Show resolved Hide resolved

enable debug mode if debug flag supplied to cli

cae4fc7

polarker reviewed Jan 18, 2024

View reviewed changes

make debug display consistent across flag/config

b31da8b

polarker merged commit cc62e49 into alephium:master Jan 22, 2024
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove cli stacktrace from cli error output #303

Remove cli stacktrace from cli error output #303

ross-weir commented Jan 16, 2024

polarker Jan 18, 2024

ross-weir Jan 21, 2024

Remove cli stacktrace from cli error output #303

Remove cli stacktrace from cli error output #303

Conversation

ross-weir commented Jan 16, 2024

polarker Jan 18, 2024

Choose a reason for hiding this comment

ross-weir Jan 21, 2024

Choose a reason for hiding this comment