Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explorer price service #295

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Explorer price service #295

merged 2 commits into from
Jan 17, 2024

Conversation

mvaivre
Copy link
Member

@mvaivre mvaivre commented Jan 3, 2024

@tdroxler please double check that everything is ok :)
Would be great to release this as soon as we agree on the last details regarding the API design:

Recap:

  • Use tokenId instead of "pseudo-symbol" as main query param
  • Add stricter type instead of Scala weird Tuple
  • Release this package

@tdroxler tdroxler force-pushed the explorer-price-service branch from 2403063 to af03224 Compare January 17, 2024 12:13
@tdroxler tdroxler marked this pull request as ready for review January 17, 2024 12:13
@tdroxler tdroxler merged commit 0759231 into master Jan 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants