Skip to content

Commit

Permalink
Standardize development dependencies
Browse files Browse the repository at this point in the history
There seems to be a preference towards using `requirements-dev.txt` vs. a `dev` extra for development dependencies, but right now neither `pip install -r requirements-dev.txt` nor `pip install -e ".[dev]" is enough to install all development dependencies.

I’ve added any dependencies listed in the `dev` extra to `requirements-dev.txt` and removed the `dev` extra so that we only have one list of dev dependencies to maintain.

This also pins the `moto` package (used to mock S3 in tests) to version 4.x as version 5 release a few days ago contains breaking changes.
  • Loading branch information
tillprochaska committed Feb 1, 2024
1 parent 46a8fc2 commit 4840b10
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 10 deletions.
1 change: 0 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ jobs:
sudo apt-get -qq update
sudo apt-get install -y libicu-dev
make dev
pip install -e ".[dev]"
- name: Run the code format check
run: make format-check
- name: Run the linter
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ build-docker:

install:
pip install -q -e .
pip install -q twine coverage nose moto boto3

dev:
python3 -m pip install --upgrade pip setuptools
Expand Down
3 changes: 3 additions & 0 deletions requirements-dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@ pytest-env==1.1.3
pytest-cov==4.1.0
pytest-mock==3.12.0
wheel==0.42.0
twine==4.0.2
moto==4.2.14
boto3==1.34.32
8 changes: 0 additions & 8 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,14 +44,6 @@
"grpcio >= 1.32.0, <2.0.0",
"google-cloud-storage >= 1.31.0, < 3.0.0",
],
"dev": [
"twine",
"moto",
"boto3 >= 1.11.9, <2.0.0",
"pytest >= 3.6",
"coverage",
"pytest-cov",
],
},
test_suite="tests",
entry_points={
Expand Down

0 comments on commit 4840b10

Please sign in to comment.