Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare release 2.4.0 #398

Merged
merged 3 commits into from
Sep 17, 2024
Merged

prepare release 2.4.0 #398

merged 3 commits into from
Sep 17, 2024

Conversation

orbeckst
Copy link
Member

@orbeckst orbeckst force-pushed the prep-release-2.4.0 branch 3 times, most recently from 84887a8 to ce93898 Compare September 17, 2024 16:25
@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.78%. Comparing base (aaf5218) to head (dadd845).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #398      +/-   ##
==========================================
- Coverage   98.78%   98.78%   -0.01%     
==========================================
  Files          28       28              
  Lines        1980     1978       -2     
  Branches      435      435              
==========================================
- Hits         1956     1954       -2     
  Misses          2        2              
  Partials       22       22

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@orbeckst
Copy link
Member Author

Note: needs to be merged (not squashed) because the blackify-commit should be on its own so that .git-ignore-revs correctly works.

@orbeckst
replace setup.py,cfg with pyproject.toml
cec46a9 
- fix #385
- use pyproject.toml instead of setup.py (note: may need to change README for PyPi to exclude
  banners)
- remove versioneer and use versioningit (use alchemlyb.__version__ directly where
  the version is needed, e.g., for sphinx docs)
- updated CHANGES for 2.4.0
@orbeckst
house-keeping
dadd845 
- gitignore _version
- ignore commits for blame that contain black-reformatting
  (in particular we forgot to include #280)
@orbeckst orbeckst self-assigned this Sep 17, 2024
@orbeckst orbeckst enabled auto-merge September 17, 2024 16:58
@orbeckst orbeckst merged commit 882ecf9 into master Sep 17, 2024
8 checks passed
@orbeckst orbeckst deleted the prep-release-2.4.0 branch September 17, 2024 18:40
@xiki-tempula
Copy link
Collaborator

Later on if I have time, I think ruff is the thing that people use now.

@xiki-tempula
Copy link
Collaborator

Might be good to squash merge next time.

@orbeckst
Copy link
Member Author

Thanks for the review.

Might be good to squash merge next time.

This needed to be merged so that commit IDs remained intact for the black-only commit or how would you have done the .git-ignore-revs?

@xiki-tempula
Copy link
Collaborator

I see. Sorry I don't quite know how git-ignore-revs works.

@orbeckst
Copy link
Member Author

https://black.readthedocs.io/en/stable/guides/introducing_black_to_your_project.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiki-tempula xiki-tempula xiki-tempula approved these changes

Assignees

@orbeckst orbeckst

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

switch from setup.py to pyproject.toml
2 participants
@orbeckst @xiki-tempula