Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capitalize GROMACS in documentation code example #356

Merged
merged 1 commit into from
May 15, 2024

Conversation

helmutcarter
Copy link
Contributor

Gromacs, as written, returns an error: "NotImplementedError: Gromacs parser not found."

Gromacs, as written, returns an error: "NotImplementedError: Gromacs parser not found."
@helmutcarter helmutcarter changed the title capitalize GROMACS capitalize GROMACS in documentation code example Apr 24, 2024
Copy link
Collaborator

@xiki-tempula xiki-tempula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for pointing this out.

Copy link
Member

@orbeckst orbeckst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@orbeckst orbeckst merged commit b2ac2f0 into alchemistry:master May 15, 2024
1 of 9 checks passed
orbeckst added a commit that referenced this pull request Sep 12, 2024
Added all authors that were mentioned in the Acknowledgements of the JOSS
paper but were not in AUTHORS

- Wei-Tse Hsu @wehs7661 (2020) for code clean-up in a732380
- Jan Janssen  @jan-janssen (2022) for creating the conda-forge package
- Shujie Fan @VOD555 (2022) for initial code for fractional equilibration time
- Helmut Carter @helmutcarter (2024) for doc fix in #356
orbeckst added a commit that referenced this pull request Sep 13, 2024
Added all authors that were mentioned in the Acknowledgements of the JOSS
paper but were not in AUTHORS

- Wei-Tse Hsu @wehs7661 (2020) for code clean-up in a732380
- Jan Janssen  @jan-janssen (2022) for creating the conda-forge package
- Shujie Fan @VOD555 (2022) for initial code for fractional equilibration time
- Helmut Carter @helmutcarter (2024) for doc fix in #356
orbeckst added a commit that referenced this pull request Sep 13, 2024
Added all authors that were mentioned in the Acknowledgements of the JOSS
paper but were not in AUTHORS

- Wei-Tse Hsu @wehs7661 (2020) for code clean-up in a732380
- Jan Janssen  @jan-janssen (2022) for creating the conda-forge package
- Shujie Fan @VOD555 (2022) for initial code for fractional equilibration time
- Helmut Carter @helmutcarter (2024) for doc fix in #356
jaclark5 pushed a commit to jaclark5/alchemlyb that referenced this pull request Sep 19, 2024
Added all authors that were mentioned in the Acknowledgements of the JOSS
paper but were not in AUTHORS

- Wei-Tse Hsu @wehs7661 (2020) for code clean-up in a732380
- Jan Janssen  @jan-janssen (2022) for creating the conda-forge package
- Shujie Fan @VOD555 (2022) for initial code for fractional equilibration time
- Helmut Carter @helmutcarter (2024) for doc fix in alchemistry#356
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants