Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #345 #351

Merged
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ jobs:
with:
environment-file: devtools/conda-envs/test_env.yaml
environment-name: test
extra-specs: |
create-args: |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this also being fixed in #346 ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes.

python=${{ matrix.python-version }}

- name: Install package (with no dependencies)
Expand Down
2 changes: 1 addition & 1 deletion devtools/conda-envs/test_env.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -24,5 +24,5 @@ dependencies:
- sphinx_rtd_theme

- pip:
- alchemtest @ https://github.com/alchemistry/alchemtest/archive/master.zip
- alchemtest @ git+https://github.com/xiki-tempula/alchemtest.git@feat_main
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change back


1 change: 1 addition & 0 deletions src/alchemlyb/tests/parsing/test_amber.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Amber parser tests.

"""

import bz2
import logging

Expand Down
2 changes: 2 additions & 0 deletions src/alchemlyb/tests/parsing/test_namd.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""NAMD parser tests.

"""

import bz2
from os.path import basename
from re import search
Expand All @@ -13,6 +14,7 @@

from alchemlyb.parsing.namd import extract_u_nk, extract


# Indices of lambda values in the following line in NAMD fepout files:
# #NEW FEP WINDOW: LAMBDA SET TO 0.6 LAMBDA2 0.7 LAMBDA_IDWS 0.5
LAMBDA1_IDX_NEW = 6
Expand Down
1 change: 1 addition & 0 deletions src/alchemlyb/tests/test_fep_estimators.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Tests for all FEP-based estimators in ``alchemlyb``.

"""

import pytest

import alchemlyb
Expand Down
1 change: 1 addition & 0 deletions src/alchemlyb/tests/test_preprocessing.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Tests for preprocessing functions.

"""

import logging

import numpy as np
Expand Down
1 change: 1 addition & 0 deletions src/alchemlyb/tests/test_ti_estimators.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Tests for all TI-based estimators in ``alchemlyb``.

"""

import pandas as pd
import pytest

Expand Down
1 change: 1 addition & 0 deletions src/alchemlyb/tests/test_ti_gaussian_quadrature.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
"""Tests for all TI-based estimators in ``alchemlyb``.

"""

import pandas as pd
import numpy as np
import copy
Expand Down
4 changes: 2 additions & 2 deletions src/alchemlyb/tests/test_workflow_ABFE.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,10 @@ def workflow(tmp_path_factory):


class TestInit:
def test_nofilematch(self):
def test_nofilematch(self, tmp_path):
with pytest.raises(ValueError, match="No file has been matched to"):
ABFE(
dir="./",
dir=str(tmp_path),
prefix="dhdl",
suffix="xvg",
T=310,
Expand Down
Loading