From c0cbc29e236131e99bc1d0ff379f8e12d74ecf64 Mon Sep 17 00:00:00 2001
From: Wh1teSh4dow <alex_unnervik@hotmail.com>
Date: Sat, 8 Mar 2014 23:24:50 +0100
Subject: [PATCH] Update FerNNClassifier.cpp

The proposed change is to the function called FerNNClassifier::getFeatures().
Originally, the function was :

  for (int t=0;t<nstructs;t++){
    leaf=0;
    for (int f=0; f<structSize; f++){
      leaf = (leaf << 1) + features[scale_idx][t*nstructs+f](image);
    }
    fern[t]=leaf;
  }

With nstructs = 10 and structSize = 13.

The issue comes from the indexes in the features function where leaf is updated. They are in reverse order. This means that not all features from 0 to 129 are used, instead only features from 0 to t*nstructs+f = 9*10 + 13 = 103 are used. We still have 130 bits in the leaf variable because some are used several times. So the algorithm relies on 104 features instead of the intended 130 which decreases the performance of it.
This correction increases the tracking performance significantly without having any impact on required processing power since the extra features we are now using are already calculated, just not used until now.

I hope I was able to improve the project.

Sincerely,
Alex
---
 src/FerNNClassifier.cpp | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/src/FerNNClassifier.cpp b/src/FerNNClassifier.cpp
index 639c65ce..1a062f0d 100644
--- a/src/FerNNClassifier.cpp
+++ b/src/FerNNClassifier.cpp
@@ -55,13 +55,13 @@ void FerNNClassifier::prepare(const vector<Size>& scales){
 }
 
 void FerNNClassifier::getFeatures(const cv::Mat& image,const int& scale_idx, vector<int>& fern){
-  int leaf;
-  for (int t=0;t<nstructs;t++){
-      leaf=0;
-      for (int f=0; f<structSize; f++){
-          leaf = (leaf << 1) + features[scale_idx][t*nstructs+f](image);
-      }
-      fern[t]=leaf;
+  for(int t=0; t<nstructs; t++)
+    fern[t] = 0;
+
+  for (int f=0; f<structSize; f++){
+  	for (int t=0; t<nstructs; t++){
+      fern[t] = (fern[t] << 1) + features[scale_idx][f*nstructs+t](image);
+    }
   }
 }