Skip to content
This repository has been archived by the owner on May 10, 2022. It is now read-only.

Commit

Permalink
Merge pull request #228 from damien-carcel/issue-227
Browse files Browse the repository at this point in the history
Issue 132: Adds GitHub templates and CONTRIBUTIING.md
  • Loading branch information
damien-carcel authored Jun 13, 2017
2 parents 548f58c + bd7d137 commit fe0cff5
Show file tree
Hide file tree
Showing 5 changed files with 46 additions and 2 deletions.
11 changes: 11 additions & 0 deletions .github/ISSUE_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
| Q | A
| ---------------------- | -----
| Bug report? | yes/no
| Feature request? | yes/no
| BC Break report? | yes/no
| RFC? | yes/no
| Affected image and tag | carcel/image:tag

<!--
- Please replace this comment by the description of your issue.
-->
23 changes: 23 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
## Description

<!--
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
- Bug fixes must be submitted against the lowest branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too):
for example apply on `php-5.6` branch, it will then be merged in `php-7.0`, and so on up to `master`.
- Documentation must be submitted against the master branch (it is not present in other branches to ease its maintenance).
-->

## Definition Of Done

| Q | A
| --------------------------------- | ---
| Added tests | Todo
| Changelog updated | Todo
| Documentation | -
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->

`Todo`: Pending / Work in progress
`OK`: Done / Validated
`-`: Not needed
10 changes: 10 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
# Contributing

These Dockerfiles are not only made for my personal use, but for anybody who likes to develop on Akeneo or Symfony applications with Docker.

I gladly accept any contributions: fixing typos, glitches, bugs, technical enhancements and new features.

For technical enhancements and new features, please first have a look at [current issues](https://github.com/damien-carcel/Dockerfiles/issues).
There may already be one, with details and ideas on how to implement it. You are welcome to pick it and propose a pull request if you'd like.

If it does not already exist, please first open an issue to describe and discuss what you want to do, it will ease the merge of your pull request.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# My Dockerfiles

This repository contains my own docker images I use for Akeneo and other Symfony development. Feel free to use/adapt them if they fit your needs.
This repository contains the Dockerfiles I use for Akeneo and other Symfony development. Feel free to use/adapt them if they fit your needs.

| [Master][Master] | [php-7.1][php-7.1] | [php-7.0][php-7.0] | [php-5.6][php-5.6] |
|:----------------:|:----------:|:----------:|:----------:|
Expand Down
2 changes: 1 addition & 1 deletion php/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ENV DEBIAN_FRONTEND noninteractive
RUN apt-get update && \
apt-get --no-install-recommends --no-install-suggests --yes --quiet install \
ca-certificates bash-completion less curl wget sudo \
mysql-client mongodb-clients vim git imagemagick perceptualdiff && \
mysql-client mongodb-clients ssh-client vim git imagemagick perceptualdiff && \
apt-get clean && apt-get --yes --quiet autoremove --purge && \
rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/* \
/usr/share/doc/* /usr/share/groff/* /usr/share/info/* /usr/share/linda/* \
Expand Down

0 comments on commit fe0cff5

Please sign in to comment.