Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default NTP configuration to ISO image cloud-init #5

Open
eak13 opened this issue Jan 28, 2021 · 1 comment
Open

Add default NTP configuration to ISO image cloud-init #5

eak13 opened this issue Jan 28, 2021 · 1 comment
Labels
enhancement New feature or request priority/low
Milestone

Comments

@eak13
Copy link

eak13 commented Jan 28, 2021

As a Image Builder user, I want to have explicit default NTP server configuration specified in the ISO cloud-init, so that I am able to override the NTP settings downstream when generating the ISO image.

Currently the NTP server is not explicitly set, so the Ubuntu default configuration is used. This prevents users from overriding the NTP server information with the own values when generating the ISO image.

Update networking data to add default NTP server entries. Update the ansible task to set the NTP server configuration based on the declared list of NTP servers.

@eak13 eak13 added the triage label Jan 28, 2021
@eak13 eak13 added this to the v2.0 milestone Jan 28, 2021
@eak13 eak13 added the enhancement New feature or request label Jan 28, 2021
@craiganderson
Copy link
Contributor

"Nice to have" story, as I don't see a reason we need precise time-keeping on a node that's only around for a few minutes during deployment.

However it should be fairly easy to do. Refer to the cloud-init updates used to configure NTP on target nodes, and include them in the ephemeral ISO secret in airshipctl manifests. You will need to change it to a string blob because that's how the ephemeral ISO cloud-init user-data is represented, and perform replacements of NTP servers using kustomize regex instead of specific data fields in YAML.

@jezogwza jezogwza removed the triage label Feb 10, 2021
@lb4368 lb4368 modified the milestones: v2.0, v2.1 Mar 10, 2021
@lb4368 lb4368 modified the milestones: v2.1, Future Apr 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request priority/low
Projects
None yet
Development

No branches or pull requests

4 participants