Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] just moving all frontend apps to the src folder #2398

Draft
wants to merge 1 commit into
base: staging
Choose a base branch
from

Conversation

Baalmart
Copy link
Collaborator

@Baalmart Baalmart commented Jan 23, 2025

  • just moving all frontend apps to the src folder

Summary by CodeRabbit

  • Cleanup
    • Removed various auto-generated configuration files for Android, iOS, and VS Code development environments
    • Deleted plugin registration files and Gradle wrapper scripts across mobile project directories

Copy link

coderabbitai bot commented Jan 23, 2025

📝 Walkthrough

Walkthrough

This pull request involves the systematic removal of several auto-generated configuration and build-related files across mobile and platform directories. The changes primarily target Flutter and Android build infrastructure files, including plugin registration scripts, Gradle wrapper scripts, and Visual Studio Code configuration files. These removals suggest a potential refactoring or restructuring of the project's build and development environment setup.

Changes

File Path Change Summary
mobile-v3/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java Deleted Flutter plugin registration file
mobile-v3/android/gradlew and mobile-v3/android/gradlew.bat Removed Gradle wrapper startup scripts for Android
mobile-v3/ios/Flutter/Generated.xcconfig Deleted iOS Flutter build configuration file
mobile-v3/ios/Flutter/flutter_export_environment.sh Removed Flutter environment export script
mobile-v3/ios/Runner/GeneratedPluginRegistrant.h and .m Deleted iOS plugin registration files
mobile/android/gradlew and mobile/android/gradlew.bat Removed additional Gradle wrapper scripts
platform/.vscode/ configs Deleted VSCode configuration files (extensions.json, settings.json, launch.json)

Possibly related PRs

  • Android build playstore #2333: Android build process modifications for Play Store deployment, potentially intersecting with plugin registration mechanisms

Poem

Farewell, generated files so neat,
Configs and wrappers now obsolete
Bits and bytes swept clean away
A digital spring cleaning's ballet 🧹✨
Code evolves, no need to fret!


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9c5ed5b and 0cd6331.

⛔ Files ignored due to path filters (73)
  • mobile-v3/android/gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
  • mobile/android/gradle/wrapper/gradle-wrapper.jar is excluded by !**/*.jar
  • src/Maintenance/www/imgs/Logo.svg is excluded by !**/*.svg
  • src/Maintenance/www/imgs/Oops.svg is excluded by !**/*.svg
  • src/calibrate/package-lock.json is excluded by !**/package-lock.json
  • src/calibrate/public/favicon-16x16.png is excluded by !**/*.png
  • src/calibrate/public/favicon-32x32.png is excluded by !**/*.png
  • src/calibrate/public/favicon-96x96.png is excluded by !**/*.png
  • src/calibrate/public/favicon.ico is excluded by !**/*.ico
  • src/calibrate/public/logo192.png is excluded by !**/*.png
  • src/calibrate/public/logo512.png is excluded by !**/*.png
  • src/calibrate/src/logo.svg is excluded by !**/*.svg
  • src/docs/_media/airqalibrate_1.png is excluded by !**/*.png
  • src/docs/_media/airqalibrate_2.png is excluded by !**/*.png
  • src/docs/_media/airqalibrate_3.png is excluded by !**/*.png
  • src/docs/_media/analytics_customisable_charts_1.png is excluded by !**/*.png
  • src/docs/_media/analytics_customisable_charts_2.png is excluded by !**/*.png
  • src/docs/_media/analytics_customisable_charts_3.png is excluded by !**/*.png
  • src/docs/_media/analytics_customisable_charts_4.png is excluded by !**/*.png
  • src/docs/_media/analytics_customisable_charts_5.png is excluded by !**/*.png
  • src/docs/_media/analytics_customisable_charts_6.png is excluded by !**/*.png
  • src/docs/_media/analytics_download_data.png is excluded by !**/*.png
  • src/docs/_media/analytics_exceedances.png is excluded by !**/*.png
  • src/docs/_media/analytics_mean_daily_pm.png is excluded by !**/*.png
  • src/docs/_media/analytics_region_status_cards.png is excluded by !**/*.png
  • src/docs/_media/analytics_select_location_1.png is excluded by !**/*.png
  • src/docs/_media/analytics_select_location_2.png is excluded by !**/*.png
  • src/docs/_media/extras_account_settings.png is excluded by !**/*.png
  • src/docs/_media/extras_add_user.png is excluded by !**/*.png
  • src/docs/_media/extras_feedback_1.png is excluded by !**/*.png
  • src/docs/_media/extras_feedback_2.png is excluded by !**/*.png
  • src/docs/_media/extras_feedback_3.png is excluded by !**/*.png
  • src/docs/_media/extras_feedback_4.png is excluded by !**/*.png
  • src/docs/_media/extras_settings.png is excluded by !**/*.png
  • src/docs/_media/favicon.png is excluded by !**/*.png
  • src/docs/_media/join_forgot_password.png is excluded by !**/*.png
  • src/docs/_media/join_request_access.png is excluded by !**/*.png
  • src/docs/_media/logo.png is excluded by !**/*.png
  • src/docs/_media/ml_based_approach_bam_1.png is excluded by !**/*.png
  • src/docs/_media/ml_based_approach_bam_2.png is excluded by !**/*.png
  • src/docs/_media/ml_based_approach_bam_3.png is excluded by !**/*.png
  • src/docs/_media/monitor_1.png is excluded by !**/*.png
  • src/docs/_media/monitor_2.png is excluded by !**/*.png
  • src/docs/_media/monitor_3.png is excluded by !**/*.png
  • src/docs/_media/monitor_4.png is excluded by !**/*.png
  • src/docs/package-lock.json is excluded by !**/package-lock.json
  • src/docs/yarn.lock is excluded by !**/yarn.lock, !**/*.lock
  • src/inventory/assets/admin/img/calendar-icons.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/gis/move_vertex_off.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/gis/move_vertex_on.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-addlink.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-alert.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-calendar.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-changelink.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-clock.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-deletelink.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-no.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-unknown-alt.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-unknown.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-viewlink.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/icon-yes.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/inline-delete.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/search.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/selector-icons.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/sorting-icons.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/tooltag-add.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/img/tooltag-arrowright.svg is excluded by !**/*.svg
  • src/inventory/assets/admin/js/vendor/jquery/jquery.min.js is excluded by !**/*.min.js
  • src/inventory/assets/admin/js/vendor/select2/select2.full.min.js is excluded by !**/*.min.js
  • src/inventory/assets/admin/js/vendor/xregexp/xregexp.min.js is excluded by !**/*.min.js
  • src/inventory/media/profile_image/download.png is excluded by !**/*.png
  • src/inventory/media/profile_image/download_l7nfOn9.png is excluded by !**/*.png
  • src/inventory/static/images/airqo_logo.png is excluded by !**/*.png
📒 Files selected for processing (12)
  • mobile-v3/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java (0 hunks)
  • mobile-v3/android/gradlew (0 hunks)
  • mobile-v3/android/gradlew.bat (0 hunks)
  • mobile-v3/ios/Flutter/Generated.xcconfig (0 hunks)
  • mobile-v3/ios/Flutter/flutter_export_environment.sh (0 hunks)
  • mobile-v3/ios/Runner/GeneratedPluginRegistrant.h (0 hunks)
  • mobile-v3/ios/Runner/GeneratedPluginRegistrant.m (0 hunks)
  • mobile/android/gradlew (0 hunks)
  • mobile/android/gradlew.bat (0 hunks)
  • platform/.vscode/extensions.json (0 hunks)
  • platform/.vscode/launch.json (0 hunks)
  • platform/.vscode/settings.json (0 hunks)
💤 Files with no reviewable changes (12)
  • platform/.vscode/settings.json
  • platform/.vscode/extensions.json
  • mobile-v3/ios/Runner/GeneratedPluginRegistrant.m
  • mobile-v3/ios/Runner/GeneratedPluginRegistrant.h
  • mobile-v3/android/gradlew.bat
  • mobile-v3/android/app/src/main/java/io/flutter/plugins/GeneratedPluginRegistrant.java
  • mobile-v3/ios/Flutter/Generated.xcconfig
  • mobile/android/gradlew
  • platform/.vscode/launch.json
  • mobile-v3/android/gradlew
  • mobile/android/gradlew.bat
  • mobile-v3/ios/Flutter/flutter_export_environment.sh

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai or @coderabbitai title anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Baalmart
Copy link
Collaborator Author

Hi @BenjaminSsempala , can you assist in finishing up this PR. Pending work is mostly around the associated CI/CD configurations so where you just add src/ at the beginning of every app's path.

@Baalmart Baalmart marked this pull request as draft January 23, 2025 14:18
@Baalmart Baalmart changed the title just moving all frontend apps to the src folder [WIP] just moving all frontend apps to the src folder Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant