Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Netmanager] Offline Mode for Map Nodes and User Stats UI #1763

Merged
merged 5 commits into from
Dec 9, 2023
Merged

[Netmanager] Offline Mode for Map Nodes and User Stats UI #1763

merged 5 commits into from
Dec 9, 2023

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Dec 9, 2023 •
edited
Loading

Summary of Changes (What does this PR do?)

  • Reactivated the offline mode for the map Nodes
  • Implemented the user stats UI page Under the User view
  • Users can now export the user List as a PDF only in the Users section.
  • Updated the ‘Roles’ icon for distinct visual representation across different tabs

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change is ready to hit production in its current state

Screenshots (optional)

image
image
image
image

@OchiengPaul442 OchiengPaul442 self-assigned this Dec 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

New netmanager changes available for preview here

@OchiengPaul442 OchiengPaul442 changed the title [Netmanager] Implemented Offline Mode for Map Nodes and User Stats UI [Netmanager] Offline Mode for Map Nodes and User Stats UI Dec 9, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

New netmanager changes available for preview here

Baalmart
Baalmart reviewed Dec 9, 2023
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @OchiengPaul442 , this is great!

  • I like the User Stats Page, that is a good place to get started
  • Just one small thing to investigate, details highlighted in the attached screenshot.
Screenshot 2023-12-09 at 17 41 54

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

New netmanager changes available for preview here

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2023

New netmanager changes available for preview here

@OchiengPaul442
Copy link
Contributor Author

Thanks @Baalmart for your feedback,
That occurs because the map is still in the process of loading the coordinates. I don’t think this is as an issue. (Loading effect)

@Baalmart
Copy link
Collaborator

Baalmart commented Dec 9, 2023

Okay @OchiengPaul442 thanks!

@Baalmart Baalmart merged commit cb5de77 into staging Dec 9, 2023
27 checks passed
@Baalmart Baalmart deleted the Net-map-visuals branch December 9, 2023 14:57
@Baalmart Baalmart mentioned this pull request Dec 9, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

@Codebmk Codebmk Awaiting requested review from Codebmk

Assignees

@OchiengPaul442 OchiengPaul442

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OchiengPaul442 @Baalmart