Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Netmanager] Team Creation Error, refactoring Horizontal Loader and Map UI Improvements v1 #1754

Merged
merged 10 commits into from
Dec 7, 2023

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Dec 5, 2023

Summary of Changes (What does this PR do?)

  • Improved Team Creation Functionality, Now Supports Missing User ID to solve the error of "creator's account is not provided"
  • Refined the user interface by repositioning the horizontal loader to sit just below the top bar for better visibility and accessibility.
  • Upgraded the map user interface by incorporating additional details, providing a more informative and user-friendly experience. This is the first version of the proposed UI enhancement.

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

Screenshots (optional)

image
imageimage

Copy link
Contributor

github-actions bot commented Dec 5, 2023

New netmanager changes available for preview here

@OchiengPaul442 OchiengPaul442 changed the title [Netmanager] Team Creation Error [Netmanager] Resolving Team Creation Error and Adjusting Horizontal Loader Position Dec 5, 2023
Copy link
Contributor

github-actions bot commented Dec 5, 2023

New netmanager changes available for preview here

1 similar comment
Copy link
Contributor

github-actions bot commented Dec 5, 2023

New netmanager changes available for preview here

Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @OchiengPaul442 , thanks for this. Much appreciated!

Just a few clarifications.... 2 of them to be precise....

  1. How is the horizontal loader supposed to work? As I was creating a site, I did notice that the horizontal loader was "fully loaded" right from the start. Is it supposed to load start from left to right and complete the horizontal width of the screen at the very end of the operation? just like how it is in Github?
  2. Secondly, I do notice that site registry table is not immediately refreshed at the end of the operation. Is this intentional behaviour?

@OchiengPaul442
Copy link
Contributor Author

Hi @Baalmart,
Thank you for your valuable feedback. The loader’s behavior is designed to mimic that of GitHub, with its fill or movement depending on the API calls made at the time.

Regarding the refresh issue, I’ve observed it in certain sections of the Netmanager as well. I am currently in the process of refactoring the existing code to address this.

@Baalmart
Copy link
Collaborator

Baalmart commented Dec 6, 2023

Hi @Baalmart, Thank you for your valuable feedback. The loader’s behavior is designed to mimic that of GitHub, with its fill or movement depending on the API calls made at the time.

Regarding the refresh issue, I’ve observed it in certain sections of the Netmanager as well. I am currently in the process of refactoring the existing code to address this.

Thanks @OchiengPaul442 for the timely response! Perhaps the loader's behaviour could also be reviewed, why does it appear fully loaded as I am still seeing the site creation screen on my end? As if it tracks some background process and not what the User is seeing.......there is some little review required there.

Thanks again!

@OchiengPaul442 OchiengPaul442 changed the title [Netmanager] Resolving Team Creation Error and Adjusting Horizontal Loader Position [Netmanager] Team Creation Error, refactoring Horizontal Loader and Map UI Improvements Dec 6, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

New netmanager changes available for preview here

@OchiengPaul442 OchiengPaul442 changed the title [Netmanager] Team Creation Error, refactoring Horizontal Loader and Map UI Improvements [Netmanager] Team Creation Error, refactoring Horizontal Loader and Map UI Improvements v1 Dec 7, 2023
Copy link
Contributor

github-actions bot commented Dec 7, 2023

New netmanager changes available for preview here

Copy link
Contributor

github-actions bot commented Dec 7, 2023

New netmanager changes available for preview here

Copy link
Contributor

github-actions bot commented Dec 7, 2023

New netmanager changes available for preview here

Copy link
Contributor

github-actions bot commented Dec 7, 2023

New netmanager changes available for preview here

1 similar comment
Copy link
Contributor

github-actions bot commented Dec 7, 2023

New netmanager changes available for preview here

Copy link
Member

@Codebmk Codebmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Loader appears below. Awesome!
image

@Baalmart Baalmart merged commit ddf8111 into staging Dec 7, 2023
27 checks passed
@Baalmart Baalmart deleted the Net-map-visuals branch December 7, 2023 13:58
@Baalmart Baalmart mentioned this pull request Dec 7, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants