-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Netmanager] Team Creation Error, refactoring Horizontal Loader and Map UI Improvements v1 #1754
Conversation
New netmanager changes available for preview here |
New netmanager changes available for preview here |
1 similar comment
New netmanager changes available for preview here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @OchiengPaul442 , thanks for this. Much appreciated!
Just a few clarifications.... 2 of them to be precise....
- How is the horizontal loader supposed to work? As I was creating a site, I did notice that the horizontal loader was "fully loaded" right from the start. Is it supposed to load start from left to right and complete the horizontal width of the screen at the very end of the operation? just like how it is in Github?
- Secondly, I do notice that site registry table is not immediately refreshed at the end of the operation. Is this intentional behaviour?
Hi @Baalmart, Regarding the refresh issue, I’ve observed it in certain sections of the Netmanager as well. I am currently in the process of refactoring the existing code to address this. |
Thanks @OchiengPaul442 for the timely response! Perhaps the loader's behaviour could also be reviewed, why does it appear fully loaded as I am still seeing the site creation screen on my end? As if it tracks some background process and not what the User is seeing.......there is some little review required there. Thanks again! |
New netmanager changes available for preview here |
New netmanager changes available for preview here |
New netmanager changes available for preview here |
New netmanager changes available for preview here |
New netmanager changes available for preview here |
1 similar comment
New netmanager changes available for preview here |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes (What does this PR do?)
Status of maturity (all need to be checked before merging):
Screenshots (optional)