Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Analytics] Customization repetition issue and Account creation fix #1740

Merged
merged 17 commits into from
Nov 29, 2023
Merged

[Analytics] Customization repetition issue and Account creation fix #1740

merged 17 commits into from
Nov 29, 2023

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Nov 28, 2023 •
edited
Loading

Summary of Changes (What does this PR do?)

  • Resolved the issue of location duplication in the customization section.
  • Implemented an alert message to notify users when they attempt to select more than four locations.
  • Enhanced the design of the account creation process to closely align with the Figma designs.
  • UI improvements on the Login page as well.
  • Some code optimization on account creation

NB: GENERAL UI FIXES AND ALIGNMENTS WITH FIGMA DESIGNS ON ALL ACCOUNT CREATION SCREENS AND LOGIN

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

NB: TO TEST OUT THE NEW UI IMPROVEMENTS PLEASE GO THROUGH THE WHOLE ACCOUNT CREATION AND LOGIN PROCESS

Screenshots (optional)

imageimage
imageimage
image

@OchiengPaul442 OchiengPaul442 self-assigned this Nov 28, 2023
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

Baalmart
Baalmart approved these changes Nov 29, 2023
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @OchiengPaul442

@Baalmart Baalmart merged commit 79d53e9 into staging Nov 29, 2023
26 of 27 checks passed
@Baalmart Baalmart deleted the analytics-customization-improvements branch November 29, 2023 09:26
@Baalmart Baalmart mentioned this pull request Nov 29, 2023
Merged
11 tasks
@github-actions GitHub Actions
Copy link
Contributor

New next-platform changes available for preview here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

@Codebmk Codebmk Awaiting requested review from Codebmk

Assignees

@OchiengPaul442 OchiengPaul442

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@OchiengPaul442 @Baalmart