Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Analytics] Implement Checklist Completion Logic and Refactor Site Selection #1709

Merged
merged 5 commits into from
Nov 21, 2023

Conversation

OchiengPaul442
Copy link
Contributor

@OchiengPaul442 OchiengPaul442 commented Nov 19, 2023

Summary of Changes (What does this PR do?)

  • Completed the implementation of the checklist completion logic.
  • Included Autosave for any changes made to the user checklist

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change is ready to hit production in its current state

Screenshots (optional)

image

Copy link
Contributor

New next-platform changes available for preview here

@Baalmart
Copy link
Collaborator

Hi @OchiengPaul442 please note that there is no need to consistently return the last 4 sites as it conflicts with the backend logic.

The backend logic always returns the last added sites at the top of the list. More like "Last In First Out"

Please review this further with others to avoid further confusion.

cc: @Codebmk @FaithDaka

Copy link
Contributor

New next-platform changes available for preview here

Copy link
Contributor

New next-platform changes available for preview here

@Baalmart Baalmart merged commit 750bcb2 into staging Nov 21, 2023
26 of 27 checks passed
@Baalmart Baalmart deleted the analytics-home-page branch November 21, 2023 10:51
@Baalmart Baalmart mentioned this pull request Nov 21, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants