Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Hotfixes] Analytics dashboard ui feedback #1667

Merged
merged 9 commits into from
Nov 13, 2023
Merged

[Hotfixes] Analytics dashboard ui feedback #1667

merged 9 commits into from
Nov 13, 2023

Conversation

Codebmk
Copy link
Member

@Codebmk Codebmk commented Nov 13, 2023

Summary of Changes (What does this PR do?)

  • Utilized circular loader for loading on analytics, cohorts registry and grids registry
  • Fixed functionality responsible for analytics air quality cards
  • Increased data export period to 5 days
  • Removed airqloud registry from sidebar

Status of maturity (all need to be checked before merging):

  • I've tested this locally
  • I consider this code done
  • This change ready to hit production in its current state

How should this be manually tested?

  • Please include the steps to be done inorder to setup and test this PR.

What are the relevant tickets?

Screenshots (optional)

Screenshot from 2023-11-13 12-56-01
Screenshot from 2023-11-13 12-53-30
Screenshot from 2023-11-13 12-53-19

@Codebmk Codebmk requested a review from Baalmart November 13, 2023 10:04
@Codebmk Codebmk self-assigned this Nov 13, 2023
@github-actions GitHub Actions
Copy link
Contributor

New netmanager changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New netmanager changes available for preview here

Baalmart
Baalmart requested changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Codebmk for this.
Let us fix the Analytics (dashboard) loading issue first .....since it is a HIGH priority issue

@github-actions GitHub Actions
Copy link
Contributor

New netmanager changes available for preview here

@github-actions GitHub Actions
Copy link
Contributor

New netmanager changes available for preview here

Baalmart
Baalmart approved these changes Nov 13, 2023
View reviewed changes
Copy link
Collaborator

@Baalmart Baalmart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Codebmk

@Baalmart Baalmart merged commit 994832d into staging Nov 13, 2023
@Baalmart Baalmart deleted the hotfixes-analytics branch November 13, 2023 15:08
@Baalmart Baalmart mentioned this pull request Nov 13, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Baalmart Baalmart Baalmart approved these changes

Assignees

@Codebmk Codebmk

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Codebmk @Baalmart