[Analytics] Air quality cards UI and functionality #1650
Conversation
|
New next-platform changes available for preview here |
1 similar comment
|
New next-platform changes available for preview here |
- set default grids to lagos, madagascar, nairobi, and kampala
|
New next-platform changes available for preview here |
|
New next-platform changes available for preview here |
| const chartDataRange = useSelector((state) => state.chart.chartDataRange); | ||
| const userDefaults = useSelector((state) => state.userDefaults.defaults); | ||
| const [grids, setGrids] = useState([ | ||
| '64b7baccf2b99f00296acd59', |
There was a problem hiding this comment.
Hi @Codebmk , thanks for this. Can we set these as variables? Somewhere in a constants file? This is just good practice. Please note that we do NOT have to create secrets or ENVs, we just need to put all constants in one place ---- as a best practice.
| const dispatch = useDispatch(); | ||
| const recentLocationMeasurements = useSelector((state) => state.recentMeasurements.measurements); | ||
| const chartDataRange = useSelector((state) => state.chart.chartDataRange); | ||
| const userDefaults = useSelector((state) => state.userDefaults.defaults); |
There was a problem hiding this comment.
Hi @Codebmk , since we are moving towards using Preferences, please consider using Preferences endpoints for this. For context, Preferences was implemented last week and it is fully ready to be utilised.
Background to this change from Defaults to Preferences:
- It was discovered that Defaults had so many issues that could not be fixed so we just decided to create a completely new set of endpoints for Analytics Redesign.
- We might also to discontinue the usage of Defaults in the Old Analytics (Netmanager) and completely switch to Preferences all throughout our Systems.
There was a problem hiding this comment.
list user preferences api says not found ie {{baseUrl}}/api/v2/users/preferences/USERID
|
New next-platform changes available for preview here |
|
New next-platform changes available for preview here |
| } | ||
| setIsLoadingMeasurements(false); | ||
| }, [userLocationsData]); | ||
|
|
There was a problem hiding this comment.
I've updated to using preferences @Baalmart
|
New next-platform changes available for preview here |
|
New next-platform changes available for preview here |
|
New next-platform changes available for preview here |
|
New next-platform changes available for preview here |
|
New next-platform changes available for preview here |
|
New next-platform changes available for preview here |
Summary of Changes (What does this PR do?)
Status of maturity (all need to be checked before merging):
How should this be manually tested?
What are the relevant tickets?
Screenshots (optional)