Adding centerAlign as a property for column headers #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssotangkur-airbnb
requested review from
alecklandgraf,
hayes,
milesj and
stefhatcher
as code owners
stefhatcher
reviewed
Apr 20, 2020
| @@ -89,11 +94,14 @@ export default function ColumnLabels({ | |||
| const sortable = | |||
| !columnMetadata || !columnMetadata[key] || columnMetadata[key].disableSorting !== 1; | |||
|
|
|||
| const alignStyle = columnMetadata?.[key]?.rightAlign ? rightAlignmentStyle : | |||
There was a problem hiding this comment.
please un-nest these nested turneries for readability.
let alignStyle = {};
if (columnMetadata?.[key]?.rightAlign) {
alignStyle = rightAlignmentStyle;
} else if (columnMetadata?.[key]?.centerAlign) {
alignStyle = centerAlignmentStyle;
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to: @milesj @stefhatcher @hayes @alecklandgraf
Description
Added a
centerAlignoption to theColumnMetadatasection of<DataTable>to allow the column headers to be center aligned.Motivation and Context
Some content looks best center aligned.
Testing
Verified it looks correct with a new story in storyboard.
Screenshots
Checklist