-
Notifications
You must be signed in to change notification settings - Fork 64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow using key columns as input to derivations #921
base: main
Are you sure you want to change the base?
Conversation
72a33db
to
cd9d1a5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you try to test the fetcher behavior on a gateway? Usually the step is:
- update an existing testing join derivation with derivation on key in the zipline_test folder
- run metadata-upload to upload the new join schema to k-v store metadata store
- upload the local jar to a remote gateway with the new change.
- run fetcher cli to validate the change
This is the procedure I am running when changing the fetcher, cc @hzding621 @pengyu-hou could you pls share if you know any simpler way to test or if there are existing doc for the testing procedure? Also pls lemme know if you need the command to run the steps.
2054fc3
to
5175c63
Compare
+1 to fetchercli testing as to what @yuli-han said |
87e434b
to
9921639
Compare
Tested with the following example: Added a rename only derivation to group by. ===== Before Fix ======= ===== Query ===== ===== Query Result ===== ===== After Fix ======= ===== Query ===== ===== Query Result ===== 2025-02-28 21:37:15 INFO Driver$FetcherCli$:750 - --- [FETCHED RESULT] --- |
Summary
Add support for using key columns as input to derivations.
Why / Goal
Test Plan
Checklist
Reviewers
@hzding621
@yuli-han