Updates after Neiry colab #165

v1docq · 2024-10-14T09:55:53Z

No description provided.

pep8speaks · 2024-10-14T09:56:09Z

Thanks for update, @v1docq!

In the file examples/real_world_examples/utils.py:

Line 24:18: F821 undefined name 'calculate_regression_metric'
Line 31:18: F821 undefined name 'init_input_data'
Line 64:18: F821 undefined name 'calculate_regression_metric'
Line 91:18: F821 undefined name 'calculate_regression_metric'

In the file fedot_ind/api/main.py:

Line 71:26: F541 f-string is missing placeholders
Line 78:26: F541 f-string is missing placeholders
Line 83:26: F541 f-string is missing placeholders
Line 437:9: E704 multiple statements on one line (def)

In the file fedot_ind/core/models/base_extractor.py:

Line 13:1: F403 'from fedot_ind.core.metrics.metrics_implementation import *' used; unable to detect undefined names
Line 24:32: F405 'Optional' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 24:41: F405 'OperationParameters' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 40:41: F405 'pd' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 47:20: F405 'pd' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 49:20: F405 'pd' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 51:52: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 61:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 64:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 71:39: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 75:19: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 75:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 76:19: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 76:28: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 79:51: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 79:91: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 85:53: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 108:54: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 143:66: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 146:51: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 147:38: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation
Line 148:20: F405 'np' may be undefined, or defined from star imports: fedot_ind.core.metrics.metrics_implementation

In the file fedot_ind/core/models/nn/network_modules/losses.py:

Line 195:5: E704 multiple statements on one line (def)
Line 317:9: F901 'raise NotImplemented' should be 'raise NotImplementedError'

In the file fedot_ind/core/repository/constanst_repository.py:

Line 19:121: E501 line too long (121 > 120 characters)

In the file fedot_ind/core/repository/excluded.py:

Line 7:1: F403 'from fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations import *' used; unable to detect undefined names
Line 105:36: F405 'PCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 106:41: F405 'FastICAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 107:46: F405 'PolyFeaturesImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations

In the file fedot_ind/core/repository/model_repository.py:

Line 10:1: F403 'from fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations import *' used; unable to detect undefined names
Line 11:121: E501 line too long (127 > 120 characters)
Line 96:20: F405 'ScalingImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 97:26: F405 'NormalizationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 99:30: F405 'ImputationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 101:23: F405 'KernelPCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 231:19: W503 line break before binary operator

Comment last updated at 2024-10-17 11:52:00 UTC

codecov · 2024-10-16T10:28:10Z

Codecov Report

Attention: Patch coverage is 66.81614% with 74 lines in your changes missing coverage. Please review.

Project coverage is 66.00%. Comparing base (6440157) to head (16cd8a3).
Report is 6 commits behind head on main.

Files with missing lines	Patch %	Lines
fedot_ind/core/models/tabular/tabular_extractor.py	0.00%	42 Missing ⚠️
fedot_ind/api/main.py	78.84%	11 Missing ⚠️
fedot_ind/api/utils/api_init.py	86.58%	11 Missing ⚠️
fedot_ind/core/models/base_extractor.py	64.28%	5 Missing ⚠️
fedot_ind/api/utils/data.py	86.66%	2 Missing ⚠️
fedot_ind/core/repository/IndustrialDispatcher.py	0.00%	2 Missing ⚠️
fedot_ind/core/optimizer/IndustrialEvoOptimizer.py	80.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #165      +/-   ##
==========================================
- Coverage   67.05%   66.00%   -1.05%     
==========================================
  Files         117      119       +2     
  Lines       11885    11977      +92     
==========================================
- Hits         7970     7906      -64     
- Misses       3915     4071     +156

Flag	Coverage Δ
unittests	`66.00% <66.81%> (-1.05%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

technocreep · 2024-10-16T11:47:30Z

fedot_ind/core/models/tabular/tabular_extractor.py

+
+    Attributes:
+        window_size (int): size of window
+        stride (int): stride for window
+        var_threshold (float): threshold for variance
+


лучше тут написать актуальную задачу генератора

technocreep · 2024-10-16T11:48:47Z

fedot_ind/core/models/tabular/tabular_extractor.py

+    def generate_features_from_ts(self,
+                                  input_data: InputData,
+                                  window_length: int = None) -> InputData:
+        feature_domain_models = [model for model in KERNEL_BASELINE_FEATURE_GENERATORS]


тут видимо KERNEL_BASELINE_FEATURE_GENERATORS.values или что-то такое

technocreep · 2024-10-16T11:49:11Z

fedot_ind/core/models/tabular/tabular_extractor.py

+
+    def generate_features_from_ts(self,
+                                  input_data: InputData,
+                                  window_length: int = None) -> InputData:


вероятно тут возвращаемый тип лист

technocreep · 2024-10-16T11:51:24Z

fedot_ind/core/models/tabular/tabular_extractor.py

+    def _transform(self, input_data: InputData) -> np.array:
+        """
+        Method for feature generation for all series
+        """
+
+        feature_list = self.generate_features_from_ts(input_data)
+        self.predict = self.create_feature_matrix(feature_list)
+        return self.predict if not self.reduce_dimension else self._reduce_dim(self.predict, input_data.target)


тут с тайпхинтами что-то перепуталось, потому что приходит не инпут дата, а лист

technocreep · 2024-10-16T11:53:02Z

fedot_ind/core/optimizer/IndustrialEvoOptimizer.py

+            try:
+                is_invalid = mutation.__name__.__contains__('resample')
+            except Exception:
+                is_invalid = mutation.name.__contains__('resample')


просто интересно, почему мы дропаем ресемпл?

v1docq and others added 7 commits September 30, 2024 15:25

neiry_example

5379995

Delete examples/real_world_examples/eeg/neiry_industrial_demo.ipynb

5741b3f

Add files via upload

69f04df

Delete examples/real_world_examples/eeg/neiry_industrial_demo.ipynb

c36d7ed

Add files via upload

e4cfffc

minor changes

81daca9

Merge remote-tracking branch 'origin/neiry_example' into neiry_example

e56f3e5

v1docq requested a review from technocreep October 14, 2024 09:55

autopep8 bot and others added 4 commits October 14, 2024 09:56

Automated autopep8 fixes

c7d4c16

fix test

a0e877b

exclude lgbm from test

91827d9

Automated autopep8 fixes

78e8a2f

technocreep added 2 commits October 16, 2024 13:26

deleted docs related files and instructions

f11c3c4

fixed docs link in readme

3620311

technocreep approved these changes Oct 16, 2024

View reviewed changes

technocreep and others added 4 commits October 16, 2024 14:47

small fix of main.finetune method and its unit test

257b24a

small fix of test_patch_tst

342860d

exclude RNN from deepAR

09ca91d

Merge remote-tracking branch 'origin/neiry_example' into neiry_example

16cd8a3

v1docq merged commit 25f5497 into main Oct 17, 2024
3 of 4 checks passed

v1docq deleted the neiry_example branch October 17, 2024 13:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates after Neiry colab #165

Updates after Neiry colab #165

v1docq commented Oct 14, 2024

pep8speaks commented Oct 14, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading

technocreep Oct 16, 2024

technocreep Oct 16, 2024

technocreep Oct 16, 2024

technocreep Oct 16, 2024

technocreep Oct 16, 2024

technocreep Oct 16, 2024

Updates after Neiry colab #165

Updates after Neiry colab #165

Conversation

v1docq commented Oct 14, 2024

pep8speaks commented Oct 14, 2024 • edited Loading

Comment last updated at 2024-10-17 11:52:00 UTC

codecov bot commented Oct 16, 2024 • edited Loading

Codecov Report

technocreep Oct 16, 2024

Choose a reason for hiding this comment

technocreep Oct 16, 2024

Choose a reason for hiding this comment

technocreep Oct 16, 2024

Choose a reason for hiding this comment

technocreep Oct 16, 2024

Choose a reason for hiding this comment

technocreep Oct 16, 2024

Choose a reason for hiding this comment

technocreep Oct 16, 2024

Choose a reason for hiding this comment

pep8speaks commented Oct 14, 2024 •

edited

Loading

codecov bot commented Oct 16, 2024 •

edited

Loading