-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ETSC models #161
base: main
Are you sure you want to change the base?
ETSC models #161
Conversation
Thanks for update, @leostre!
Comment last updated at 2024-07-26 12:35:51 UTC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
видна отличная рисерч работа.
я позволил себе накидать пока какие-то очевидные правки.
из общего хочу отметить еще нехватку:
- примеров запуска новых моделей и их сравнения
- докстрингов к новым моделям (пояснить в google style, что за модель, в чем ее фишка и принцип работы - стоит посмотреть доки sktime)
- докстрингов в базовом классе BaseETC и его неочевидный на первый вгляд нейминг (предлагаю
EarlyTSClassifier
) - юнитов для добавленных моделей
Co-authored-by: George Lopatenko <81328772+Lopa10ko@users.noreply.github.com>
Added Early Time Series Classification models including
Economy K, ECEC, Probability Thresholding, TEASER