Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model Repository Parser for UML Diagrams #144

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Conversation

ismonnar
Copy link
Collaborator

Парсер репозитория моделей для создания UML-диаграмм

@pep8speaks
Copy link

pep8speaks commented May 24, 2024

Thanks for update, @ismonnar!

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-06-13 11:22:27 UTC

@technocreep technocreep self-assigned this May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.72%. Comparing base (4b271c1) to head (27c364c).
Report is 73 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
- Coverage   56.17%   48.72%   -7.46%     
==========================================
  Files         102      112      +10     
  Lines        9025    10957    +1932     
==========================================
+ Hits         5070     5339     +269     
- Misses       3955     5618    +1663     
Flag Coverage Δ
unittests 48.72% <ø> (-7.46%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@technocreep technocreep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

добавил тебя в разрабы репоза, чтобы не делать ПР из форка

сделай плиз чекаут от мэйна и оформи ПР уже из ветки индастриала

Copy link
Collaborator

@technocreep technocreep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

всё супер, лишь один момент поправить и можно вливать

uml/uml.py Outdated
Comment on lines 4 to 6
with open('../fedot_ind/core/repository/model_repository.py', 'r') as file:
file_content = [string for string in file.read().split("\n") if not string.startswith("from")]
file_content = file_content[:next((i for i, line in enumerate(file_content) if line.startswith("def")), None)]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

я кажется упоминал, что лучше привязываться к project_path из path_lib

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

изменил файл
вы ещё просили добавить его в директорию tools - тоже сделал

@technocreep technocreep added the enhancement New feature or request label Jun 10, 2024
@technocreep technocreep merged commit e66a123 into aimclub:main Jun 13, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants