Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix nn loss, fix model selecting #123

Merged
merged 10 commits into from
Mar 4, 2024
Merged

fix nn loss, fix model selecting #123

merged 10 commits into from
Mar 4, 2024

Conversation

v1docq
Copy link
Collaborator

@v1docq v1docq commented Feb 26, 2024

No description provided.

@v1docq v1docq requested a review from technocreep February 26, 2024 08:52
@pep8speaks
Copy link

pep8speaks commented Feb 26, 2024

Thanks for update, @v1docq!

Line 105:34: E231 missing whitespace after ','

Line 5:1: F401 'scipy' imported but unused
Line 6:1: F401 'sklearn' imported but unused

Line 12:1: F401 'fedot.core.pipelines.tuning.tuner_builder.TunerBuilder' imported but unused
Line 21:1: F401 'fedot_ind.core.repository.constanst_repository.FEDOT_HEAD_ENSEMBLE' imported but unused
Line 149:32: F841 local variable 'n_classes' is assigned to but never used
Line 150:44: E127 continuation line over-indented for visual indent
Line 151:44: E127 continuation line over-indented for visual indent
Line 169:79: E127 continuation line over-indented for visual indent
Line 397:54: F541 f-string is missing placeholders

Line 8:1: F401 'sklearn.model_selection.StratifiedKFold' imported but unused
Line 8:1: F401 'sklearn.model_selection.StratifiedGroupKFold' imported but unused
Line 8:1: F401 'sklearn.model_selection.train_test_split' imported but unused
Line 10:1: F401 'fedot_ind.core.repository.constanst_repository.FEDOT_ENSEMBLE_ASSUMPTIONS' imported but unused
Line 89:55: W503 line break before binary operator
Line 90:9: E265 block comment should start with '# '
Line 90:121: E501 line too long (126 > 120 characters)

Line 16:1: F403 'from fedot_ind.core.metrics.metrics_implementation import ' used; unable to detect undefined names
Line 16:1: F401 'fedot_ind.core.metrics.metrics_implementation.
' imported but unused

Line 46:121: E501 line too long (121 > 120 characters)

Line 125:9: E704 multiple statements on one line (def)
Line 128:9: E704 multiple statements on one line (def)
Line 132:9: E704 multiple statements on one line (def)
Line 137:9: E704 multiple statements on one line (def)

Line 23:1: F403 'from fedot_ind.core.models.topological.topofeatures import ' used; unable to detect undefined names
Line 23:1: F401 'fedot_ind.core.models.topological.topofeatures.
' imported but unused

Line 4:1: F401 'fedot.core.data.merge.data_merger.DataMerger' imported but unused
Line 15:1: F401 'typing.Tuple' imported but unused
Line 15:1: F401 'typing.Sequence' imported but unused
Line 15:1: F401 'typing.Dict' imported but unused
Line 16:1: F401 'golem.core.optimisers.timer.Timer' imported but unused
Line 18:1: F401 'fedot.core.pipelines.node.PipelineNode' imported but unused

Line 78:9: F841 local variable 'MutationStrengthEnum' is assigned to but never used

Line 14:1: F403 'from fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations import *' used; unable to detect undefined names
Line 19:5: E116 unexpected indentation (comment)
Line 69:36: F405 'PCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 70:41: F405 'FastICAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 71:46: F405 'PolyFeaturesImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 127:20: F405 'ScalingImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 128:26: F405 'NormalizationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 130:30: F405 'ImputationImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations
Line 132:23: F405 'KernelPCAImplementation' may be undefined, or defined from star imports: fedot.core.operations.evaluation.operation_implementations.data_operations.sklearn_transformations

Line 82:9: E123 closing bracket does not match indentation of opening bracket's line
Line 116:9: E123 closing bracket does not match indentation of opening bracket's line
Line 132:9: E123 closing bracket does not match indentation of opening bracket's line
Line 154:9: E123 closing bracket does not match indentation of opening bracket's line
Line 160:9: E123 closing bracket does not match indentation of opening bracket's line
Line 166:9: E123 closing bracket does not match indentation of opening bracket's line
Line 184:9: E123 closing bracket does not match indentation of opening bracket's line
Line 202:9: E123 closing bracket does not match indentation of opening bracket's line
Line 220:9: E123 closing bracket does not match indentation of opening bracket's line
Line 238:9: E123 closing bracket does not match indentation of opening bracket's line
Line 252:9: E123 closing bracket does not match indentation of opening bracket's line
Line 270:9: E123 closing bracket does not match indentation of opening bracket's line
Line 284:9: E123 closing bracket does not match indentation of opening bracket's line
Line 298:9: E123 closing bracket does not match indentation of opening bracket's line
Line 312:9: E123 closing bracket does not match indentation of opening bracket's line
Line 326:9: E123 closing bracket does not match indentation of opening bracket's line
Line 344:9: E123 closing bracket does not match indentation of opening bracket's line
Line 360:9: E123 closing bracket does not match indentation of opening bracket's line
Line 370:9: E123 closing bracket does not match indentation of opening bracket's line
Line 392:9: E123 closing bracket does not match indentation of opening bracket's line
Line 417:9: E123 closing bracket does not match indentation of opening bracket's line
Line 459:9: E123 closing bracket does not match indentation of opening bracket's line
Line 475:9: E123 closing bracket does not match indentation of opening bracket's line
Line 481:9: E123 closing bracket does not match indentation of opening bracket's line
Line 491:9: E123 closing bracket does not match indentation of opening bracket's line
Line 501:9: E123 closing bracket does not match indentation of opening bracket's line
Line 519:9: E123 closing bracket does not match indentation of opening bracket's line
Line 537:9: E123 closing bracket does not match indentation of opening bracket's line
Line 551:9: E123 closing bracket does not match indentation of opening bracket's line
Line 565:9: E123 closing bracket does not match indentation of opening bracket's line
Line 575:9: E123 closing bracket does not match indentation of opening bracket's line
Line 585:9: E123 closing bracket does not match indentation of opening bracket's line
Line 595:9: E123 closing bracket does not match indentation of opening bracket's line
Line 601:9: E123 closing bracket does not match indentation of opening bracket's line
Line 607:9: E123 closing bracket does not match indentation of opening bracket's line
Line 621:9: E123 closing bracket does not match indentation of opening bracket's line
Line 627:9: E123 closing bracket does not match indentation of opening bracket's line
Line 633:9: E123 closing bracket does not match indentation of opening bracket's line
Line 647:9: E123 closing bracket does not match indentation of opening bracket's line
Line 653:9: E123 closing bracket does not match indentation of opening bracket's line
Line 683:9: E123 closing bracket does not match indentation of opening bracket's line
Line 709:9: E123 closing bracket does not match indentation of opening bracket's line
Line 731:9: E123 closing bracket does not match indentation of opening bracket's line
Line 753:9: E123 closing bracket does not match indentation of opening bracket's line
Line 767:9: E123 closing bracket does not match indentation of opening bracket's line
Line 777:9: E123 closing bracket does not match indentation of opening bracket's line
Line 783:9: E123 closing bracket does not match indentation of opening bracket's line
Line 789:9: E123 closing bracket does not match indentation of opening bracket's line
Line 796:9: E123 closing bracket does not match indentation of opening bracket's line
Line 810:9: E123 closing bracket does not match indentation of opening bracket's line

Comment last updated at 2024-03-04 15:03:43 UTC

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

Attention: Patch coverage is 43.05556% with 41 lines in your changes are missing coverage. Please review.

Project coverage is 56.19%. Comparing base (a473df9) to head (e4de150).
Report is 1 commits behind head on main.

Files Patch % Lines
fedot_ind/api/main.py 30.55% 25 Missing ⚠️
...t_ind/core/models/nn/network_impl/base_nn_model.py 11.11% 8 Missing ⚠️
fedot_ind/core/ensemble/random_automl_forest.py 0.00% 5 Missing ⚠️
...core/operation/transformation/basis/eigen_basis.py 50.00% 2 Missing ⚠️
...on/interfaces/industrial_preprocessing_strategy.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
- Coverage   56.28%   56.19%   -0.09%     
==========================================
  Files         102      102              
  Lines        9004     9018      +14     
==========================================
  Hits         5068     5068              
- Misses       3936     3950      +14     
Flag Coverage Δ
unittests 56.19% <43.05%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Comment on lines +157 to +160
try:
svd_numbers = [self._transform_one_sample(signal, svd_flag=True) for signal in data[:, 0, :]]
except Exception:
_ = 1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

видимо этот _ = 1 было написано для отладки?

@technocreep technocreep merged commit d24a842 into main Mar 4, 2024
7 checks passed
MisterZurg pushed a commit to MisterZurg/Fedot.Industrial that referenced this pull request Apr 22, 2024
* fix nn loss, fix model selecting
* update benchmark results
* refactoring raf algo
* add kaggle model
---------

Co-authored-by: v1docq <ir@raxeltelematics.com>
Co-authored-by: technocreep <aspirantvadim@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants