Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Illustrate new failing scenario with multi-arg function identifiers #996

Merged
merged 4 commits into from
Aug 10, 2024

Conversation

KtorZ
Copy link
Member

@KtorZ KtorZ commented Aug 6, 2024

As far as I could tell, this behavior is only observed when the arity
of the function is higher than 1. It's fine for single-arg functions
somehow.

@KtorZ KtorZ self-assigned this Aug 6, 2024
@KtorZ KtorZ requested a review from a team as a code owner August 6, 2024 15:01
@MicroProofs
Copy link
Member

I decided to separate out what I did in soft casting. So I'll make the commit fix here.

KtorZ added 3 commits August 8, 2024 14:52
  Let's consider the following case:

  ```
  type Var =
    Integer

  type Vars =
    List<Var>
  ```

  This incorrectly reports an infinite cycle; due to the inability to
  properly type-check `Var` which is also a dependent var of `Vars`. Yet
  the real issue here being that `Integer` is an unknown type.

  This commit also upgrades miette to 7.2.0, so that we can also display
  a better error output when the problem is actually a cycle.
  As far as I could tell, this behavior is only observed when the arity
  of the function is higher than 1. It's fine for single-arg functions
  somehow.
@MicroProofs MicroProofs force-pushed the acceptance-scenario-108 branch from 0027451 to 6e4a16d Compare August 8, 2024 18:52
… functions that were passed as arguments to other functions
@KtorZ KtorZ merged commit 3b94717 into main Aug 10, 2024
12 checks passed
@KtorZ KtorZ deleted the acceptance-scenario-108 branch August 10, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Released
Development

Successfully merging this pull request may close these issues.

2 participants