Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minimal pallas dependencies #949

Merged
merged 2 commits into from
May 30, 2024
Merged

Minimal pallas dependencies #949

merged 2 commits into from
May 30, 2024

Conversation

hadelive
Copy link
Contributor

No description provided.

@hadelive hadelive requested a review from a team as a code owner May 30, 2024 03:53
@hadelive hadelive force-pushed the minimal-pallas-deps branch 6 times, most recently from d8b678b to 3b5c279 Compare May 30, 2024 07:20
KtorZ
KtorZ approved these changes May 30, 2024
View reviewed changes
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet gesture! Were you listening to our private conversations lately 😅? Because I was talking about how we were importing too many stuff from pallas that weren't needed because of the workspace mode! I guess that's one item ticked off the TODO list.

Thanks.

@hadelive hadelive force-pushed the minimal-pallas-deps branch from 3b5c279 to f729ecd Compare May 30, 2024 08:08
@hadelive hadelive force-pushed the minimal-pallas-deps branch from f729ecd to ad3c9f2 Compare May 30, 2024 08:09
@solidsnakedev
Copy link
Contributor

Sweet gesture! Were you listening to our private conversations lately 😅? Because I was talking about how we were importing too many stuff from pallas that weren't needed because of the workspace mode! I guess that's one item ticked off the TODO list.

Thanks.

We were discussing about this internally at AL yesterday lol , thank you @KtorZ for taking this PR

@KtorZ KtorZ merged commit 4c1bee5 into aiken-lang:main May 30, 2024
8 checks passed
@hadelive hadelive deleted the minimal-pallas-deps branch May 30, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KtorZ KtorZ KtorZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
Project Tracking
Status: 🚀 Released
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hadelive @solidsnakedev @KtorZ