Modify blueprint schema to properly handle pairs #938
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KtorZ
requested changes
May 12, 2024
| @@ -92,6 +92,7 @@ pub enum Data { | |||
| Integer, | |||
| Bytes, | |||
| List(Items<Data>), | |||
| Pair(Declaration<Data>, Declaration<Data>), | |||
There was a problem hiding this comment.
This isn't right, a Pair cannot be a Plutus' Data.
| @@ -297,18 +298,11 @@ impl Annotated<Schema> { | |||
| // make all types abide by this convention. | |||
| let data = match definitions.try_lookup(&generic).cloned() { | |||
| Some(Annotated { | |||
| annotated: Schema::Data(Data::List(Items::Many(xs))), | |||
| annotated: Schema::Data(Data::Pair(left, right)), | |||
There was a problem hiding this comment.
The schema here should likely be Pair, not Data
There was a problem hiding this comment.
Hmm I'll have to look into the conversion from Schema::Pair into a Schema of Data to handle the Map case
| Data::Pair(left, right) => { | ||
| let mut s = serializer.serialize_struct("Pair", 2)?; | ||
| s.serialize_field("dataType", "list")?; | ||
| s.serialize_field("items", &[left, right])?; |
There was a problem hiding this comment.
That doesn't match CIP-0057´s specification though 😶
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.