Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Install shell completions automatically #809

Merged
merged 9 commits into from
May 10, 2024

Conversation

freexploit
Copy link
Contributor

@freexploit freexploit commented Jan 26, 2024

  • Adding a --install flag to the Aiken completion command. When you set this flag to true, Aiken will write to a file instead of just showing you the output.
  • Zsh support on linux (basic no plugins like oh-my-zsh yet)
  • Fish support on linux
  • Bash support on linux
  • Tweaking aikup so it automatically runs aiken completion $SHELL --install every time you install a new version.

@freexploit freexploit force-pushed the add-completion-install branch from f83f10b to 17b436d Compare January 26, 2024 03:56
@freexploit freexploit force-pushed the add-completion-install branch from c042f70 to 9b625cc Compare February 17, 2024 17:37
@freexploit freexploit force-pushed the add-completion-install branch from 9b625cc to 6a8eff6 Compare March 29, 2024 17:21
@freexploit freexploit marked this pull request as ready for review April 2, 2024 23:53
@freexploit freexploit requested a review from a team as a code owner April 2, 2024 23:53
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I kindly request a few additions on the error context. As much as possible, we should strive for errors to be helpful and provide all the context necessary to troubleshoot problems 👍

crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
crates/aiken/src/cmd/completion/completion.rs Outdated Show resolved Hide resolved
@freexploit freexploit force-pushed the add-completion-install branch from ef8e390 to 9d4c09c Compare April 28, 2024 23:04
@freexploit freexploit requested a review from KtorZ May 4, 2024 22:07
Copy link
Member

@KtorZ KtorZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks ❤️

@KtorZ KtorZ merged commit 83c0566 into aiken-lang:main May 10, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🚀 Released
Development

Successfully merging this pull request may close these issues.

2 participants