Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commands about download planner and related dependencies #117

Open
jsego opened this issue Feb 26, 2018 · 4 comments
Open

Commands about download planner and related dependencies #117

jsego opened this issue Feb 26, 2018 · 4 comments

Comments

@jsego
Copy link
Member

jsego commented Feb 26, 2018

  1. When executing this line:
    git clone --branch=v2 https://github.com/aig-upf/fs.git fs-planner
    It uses the public repository where branch v2 does not exist (either create a new branch in public or modify the command referencing the private repository)

  2. I get this output when I try to execute git submodule update --init

Cloning into 'submodules/lapkt-base'...
Permission denied (publickey).
fatal: Could not read from remote repository.
Please make sure you have the correct access rights
and the repository exists.
fatal: clone of 'git@github.com:aig-upf/lapkt-base.git' into submodule path 'submodules/lapkt-base' failed

It stops at this point but I guess same happens with rapidjson submodule.
My workaround for lapkt was to execute git submodule add https://github.com/aig-upf/lapkt-base .

@ssardina
Copy link
Collaborator

Hola Sergio,

I have been using this in the last couple of weeks too :-)

  1. Why are you not doing;
    git clone --branch=v2 https://github.com/aig-upf/fs-private.git

I was able to do that and then git submodules worked out well:

[ssardina@Thinkpad-X1 fs-private]$ git submodule update --init
Submodule 'submodules/lapkt-base' (git@github.com:aig-upf/lapkt-base.git) registered for path 'submodules/lapkt-base'
Submodule 'submodules/lapkt-novelty' (git@github.com:aig-upf/lapkt-novelty.git) registered for path 'submodules/lapkt-novelty'
Submodule 'submodules/rapidjson' (git@github.com:Tencent/rapidjson.git) registered for path 'submodules/rapidjson'
Cloning into 'submodules/lapkt-base'...
remote: Counting objects: 5887, done.
remote: Total 5887 (delta 0), reused 0 (delta 0), pack-reused 5887
Receiving objects: 100% (5887/5887), 7.24 MiB | 429.00 KiB/s, done.
Resolving deltas: 100% (3276/3276), done.
Checking connectivity... done.
Submodule path 'submodules/lapkt-base': checked out 'cb9169c8bbec83ba78d1514ea93f2929fa9e8a43'
Cloning into 'submodules/lapkt-novelty'...
remote: Counting objects: 235, done.
remote: Total 235 (delta 0), reused 0 (delta 0), pack-reused 235
Receiving objects: 100% (235/235), 43.76 KiB | 0 bytes/s, done.
Resolving deltas: 100% (116/116), done.
Checking connectivity... done.
Submodule path 'submodules/lapkt-novelty': checked out '2b3285d9afca90b7df5ea38ea9f58c991e9cf5ee'
Cloning into 'submodules/rapidjson'...
remote: Counting objects: 19875, done.
remote: Compressing objects: 100% (21/21), done.
remote: Total 19875 (delta 27), reused 15 (delta 13), pack-reused 19841
Receiving objects: 100% (19875/19875), 22.89 MiB | 1.44 MiB/s, done.
Resolving deltas: 100% (14941/14941), done.
Checking connectivity... done.
Submodule path 'submodules/rapidjson': checked out '17ae6ffa857173c25708e61610121bc908c0a6cd'
[ssardina@Thinkpad-X1 fs-private]$ 

@nirlipo
Copy link
Member

nirlipo commented Feb 26, 2018

Hi Javi, make sure that you have access to github with SSH.

Test if it's working correctly as explained here:

https://help.github.com/articles/testing-your-ssh-connection/

and if it fails, follow this instructions:

https://help.github.com/articles/connecting-to-github-with-ssh/

@jsego
Copy link
Member Author

jsego commented Feb 26, 2018

Hi Sebastian,

I am Javi, sorry for the confusion. Regarding the first point, referencing the private repository works I only mentioned it should be modified in the documentation. And in the second point, it seems that I didn't set the SSH key to my user account that is a requirement to update submodules. Thank you very much for the fast reply.

Javi

@gfrances
Copy link
Member

Yup, the documentation is not modified as this will eventually be made public and moved to the standard fs repo. Yes, I could change it by then again, but I'm too lazy :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants