Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add functionality for checking for a new version #1064

Open
wants to merge 2 commits into
base: development
Choose a base branch
from

Conversation

swivelmargarita
Copy link

@swivelmargarita swivelmargarita commented Apr 19, 2024

There was a commented out code for this functionality in utils.cpp, but when I tested that code it would evaluate the version wrong.
I tried to add a way to check if a new version available from the github releases. If so it redirects to the github release site.
If there's something I overlooked, I'd appreciate feedback, thanks.

I added a test case(it emulates when there's a new version) where the version obtained from github releases(69.420.0) is different than current version(2.0.0). It works as expected.
image

swivel added 2 commits April 19, 2024 17:12
…'t return the version but some gibberish html element.

 Update the user update dialog.
@swivelmargarita swivelmargarita changed the title Add functionality for checking for an new version Add functionality for checking for a new version Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant