Move rustfmt and clippy into Makefile targets

.github/workflows/rust.yml

@@ -56,14 +56,8 @@ jobs:
         uses: actions/checkout@v3
       - name: Install rustfmt
         run: rustup component add rustfmt
-      - name: Check aws-crt-s3-sys
-        run: cargo fmt --manifest-path aws-crt-s3-sys/Cargo.toml -- --check
-      - name: Check aws-crt-s3
-        run: cargo fmt --manifest-path aws-crt-s3/Cargo.toml -- --check
-      - name: Check s3-client
-        run: cargo fmt --manifest-path s3-client/Cargo.toml -- --check
-      - name: Check s3-file-connector
-        run: cargo fmt --manifest-path s3-file-connector/Cargo.toml -- --check
+      - name: Check format
+        run: make fmt-check
 
   clippy:
     name: Clippy
@@ -77,4 +71,4 @@ jobs:
       - name: Install fuse
         run: sudo apt-get install fuse libfuse2 libfuse-dev
       - name: Run Clippy
-        run: cargo clippy -p aws-crt-s3 -p s3-client -p aws-s3-fuse --no-deps --all-targets -- -D clippy::all
+        run: make clippy

Makefile

@@ -0,0 +1,32 @@
+# Most of these targets just exist so we can avoid running clippy and rustfmt on the vendored
+# fuser crate. If those tools ever get stabilized `ignore` features, or we stop vendoring, this can
+# go away.
+
+CRATES = aws-crt-s3-sys aws-crt-s3 s3-client s3-file-connector
+
+.PHONY: all
+all:
+	cargo build --all-targets
+
+.PHONY: release
+release:
+	cargo build --release --all-targets
+
+.PHONY: fmt
+fmt:
+	@for crate in $(CRATES); do \
+		cargo fmt --manifest-path $$crate/Cargo.toml; \
+	done
+
+.PHONY: fmt-check
+fmt-check:
+	@fail=0; \
+	for crate in $(CRATES); do \
+		cargo fmt --manifest-path $$crate/Cargo.toml -- --check || fail=1; \
+	done; \
+	exit $$fail
+
+.PHONY: clippy
+clippy:
+	packages=`echo "$(CRATES)" | sed -E 's/(^| )/ -p /g'`; \
+	cargo clippy $$packages --no-deps --all-targets -- -D clippy::all

aws-crt-s3-sys/src/lib.rs

@@ -4,7 +4,8 @@
     non_snake_case,
     unused,
     rustdoc::broken_intra_doc_links,
-    rustdoc::bare_urls
+    rustdoc::bare_urls,
+    clippy::all
 )]
 mod generated {
     include!(concat!(env!("OUT_DIR"), "/bindings.rs"));

rustfmt.toml

@@ -1,2 +1 @@
 max_width = 120
-ignore = ["vendor/"]

s3-file-connector/Cargo.toml

@@ -1,5 +1,5 @@
 [package]
-name = "aws-s3-fuse"
+name = "s3-file-connector"
 version = "0.1.0"
 edition = "2021"
 publish = false

s3-file-connector/tests/common/mod.rs

@@ -1,6 +1,6 @@
-use aws_s3_fuse::fs::S3Filesystem;
 use fuser::{BackgroundSession, MountOption, Session};
 use s3_client::{S3Client, S3ClientConfig};
+use s3_file_connector::fs::S3Filesystem;
 use tempfile::TempDir;
 
 pub fn make_test_session() -> (TempDir, BackgroundSession) {